You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Shopify will return the following liquid error on page load:
Liquid error: Input must be a theme or shop asset URL.
Expected
I expected that either the preload_tag would work with 3rd party assets or that the AssetPreload wouldn't give a false positive that leads to a liquid error.
Additional context
theme-check --version
1.12.1
The text was updated successfully, but these errors were encountered:
👋🏻 Hi @nickbabcock! Thanks for reporting this. Unfortunately the Ruby version of theme check has been deprecated for some time. Would you be able to confirm you are still having issues when using our maintained version of theme check? This is done using either the latest version of the Shopify CLI, or via the Shopify Liquid Visual Studio Code extension.
If you are still having issues, please raise an issue over in the CLI or theme tools repositories. Thanks!
Describe the bug
The AssetPreload lint fires on the following line:
If we take the suggestion and preload this 3rd party asset with the
preload_tag
Shopify will return the following liquid error on page load:
Expected
I expected that either the
preload_tag
would work with 3rd party assets or that the AssetPreload wouldn't give a false positive that leads to a liquid error.Additional context
The text was updated successfully, but these errors were encountered: