Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

[Intelligent code completion] Make suggestions for paginate #683

Closed
Poitrin opened this issue Dec 13, 2022 · 0 comments · Fixed by #686
Closed

[Intelligent code completion] Make suggestions for paginate #683

Poitrin opened this issue Dec 13, 2022 · 0 comments · Fixed by #686
Assignees
@Poitrin
Labels
bug Something isn't working

Comments

@Poitrin
Copy link
Contributor

Poitrin commented Dec 13, 2022 •
edited

Describe the bug / Actual
For {%- paginate , no suggestions are made.

13-59-r66ws-nphn5

Inspired by: https://github.com/Shopify/dawn/blob/main/sections/main-addresses.liquid#L19

Expected
For {%- paginate , suggestions should be made, the same way they are done for e.g. {%- echo

13-02-b7gh7-xqcbo

Debugging information

  • OS: macOS
  • Version: 1.12.0
@Poitrin Poitrin added the bug Something isn't working label Dec 13, 2022
@Poitrin Poitrin self-assigned this Dec 14, 2022
This was referenced Dec 14, 2022
Merged
Closed
Poitrin pushed a commit that referenced this issue Dec 14, 2022
Suggest objects for paginate (#686)
b587f7d 
### WHY are these changes introduced?

Fixes #683 

### WHAT is this pull request doing?

Treats `paginate` in a similar way as `echo`, so that suggestions are shown.

Use cases like `{% paginate customer.orders` will be treated in #687.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Poitrin Poitrin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suggest objects for paginate Shopify/theme-check
1 participant
@Poitrin