Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mount rack app at application level #238

Closed
wants to merge 1 commit into from
Closed

Don't mount rack app at application level #238

wants to merge 1 commit into from

Commits on Jan 31, 2024

  1. Don't mount rack app at application level 

    This causes Rails middleware like ActiveRecord::Migration::CheckPending
to get in the way of LSP requests. We should surface migration errors
in the LSP instead of having features just stop working.
    @gmcgibbon
    gmcgibbon committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    02a9d26 View commit details
    Browse the repository at this point in the history