Don't mount rack app at application level

[gmcgibbon]

Don't mount rack app at application level

This causes Rails middleware like ActiveRecord::Migration::CheckPending to get in the way of LSP requests. If we could surface migration issues somewhere else using the LSP, that would be nice.

Currently, if you generate a migration on a project using the LSP, you get this error on hovering over a model:

Started GET "/ruby_lsp_rails/models/Article" for ::1 at 2024-01-31 11:25:32 -0600
  ActiveRecord::SchemaMigration Load (0.0ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC

ActiveRecord::PendingMigrationError (

Migrations are pending. To resolve this issue, run:

        bin/rails db:migrate

You have 1 pending migration:

db/migrate/20240131171953_add_a_to_b.rb


):

activerecord (7.1.3) lib/active_record/migration.rb:755:in `check_pending_migrations'
activerecord (7.1.3) lib/active_record/migration.rb:644:in `block (2 levels) in call'
activesupport (7.1.3) lib/active_support/file_update_checker.rb:85:in `execute'
activesupport (7.1.3) lib/active_support/file_update_checker.rb:95:in `execute_if_updated'
...

[andyw8]

👋 We're planning to move away from the Rack approach, so this probably won't be necessary: #230

[gmcgibbon]

That looks like a much better approach. If we don't need to have the Rails server running, that's far more convenient. Closing for now.