Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for taint checking #1268

Merged
merged 2 commits into from
Jul 26, 2020
Merged

Conversation

dylanahsmith
Copy link
Contributor

Problem

Running the tests with on ruby 2.7 results in a lot of deprecation warnings like

.../lib/liquid/standardfilters.rb:44: warning: Object#untaint is deprecated and will be removed in Ruby 3.2.

which are from ruby deprecating taint checking.

I was also seeing multiple of the following deprecation warning when running the tests

.../.gem/ruby/2.7.1/gems/rake-11.3.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil

Solution

Remove support for taint checking and upgrade the development version of rake.

Gets rid of a deprecation warning when running the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants