Fix infinite redirect when a double slash appears in a URL #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
blittle
commented
Aug 19, 2024
blittle
commented
Aug 19, 2024
| @@ -10,13 +10,12 @@ import type {ViteDevServer} from 'vite'; | |||
| */ | |||
| export function toURL(req: string | IncomingMessage = '/', origin?: string) { | |||
| const isRequest = typeof req !== 'string'; | |||
| const pathname = (isRequest ? req.url : req) || '/'; | |||
There was a problem hiding this comment.
Instead of using the second argument to new URL, just manually concatenate the origin with the pathname.
wizardlyhel
approved these changes
Aug 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Take @brophdawg11's suggestion to resolve this in Oxygen: double slash followed by any char after domain causes infinite page reloading remix-run/remix#9692 (comment) by detecting the double slash, and redirecting with a single slash. I assume this is okay? Are there situations where the URL might have encoded data with a double slash that would break?
Fix a bug where in local development the request object would not contain the
localhostdomain becausenew URL('//test', 'http://localhost/').hrefproducehttp://test/'🎩
http://localhost:3000//test. Should redirect with the double slash removed.http://localhost:3000/products//snowboard. Should redirect with the double slash removed.