double slash followed by any char after domain causes infinite page reloading

[dimanche-matin]

Reproduction

Add double slash followed by any char after domain (e.g. https://example.com//foo), then Enter.

System Info

System:
    OS: macOS 14.5
    CPU: (8) arm64 Apple M1
    Memory: 59.33 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.7.1 - /opt/homebrew/bin/node
    Yarn: 1.22.21 - /opt/homebrew/bin/yarn
    npm: 10.5.0 - /opt/homebrew/bin/npm
  Browsers:
    Brave Browser: 125.1.66.115
    Chrome: 126.0.6478.127
    Edge: 126.0.2592.81
    Safari: 17.5
  npmPackages:
    @remix-run/dev: ^2.9.2 => 2.9.2 
    @remix-run/node: ^2.9.2 => 2.9.2 
    @remix-run/react: ^2.9.2 => 2.9.2 
    @remix-run/serve: ^2.9.2 => 2.9.2 
    vite: ^5.1.0 => 5.2.13

Used Package Manager

npm

Expected Behavior

404 Not Found

Actual Behavior

Infinite reloading with this console error log:
"Initial URL (/) does not match URL at time of hydration (//foo), reloading page..."

Some web sites listed on https://remix.run/showcase are affected.

[brophdawg11]

This should be resolved via #9695 and available in the next release 👍

[github-actions]

🤖 Hello there,

We just published version 2.11.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[dimanche-matin]

Bug persists on 2.11.0-pre.0.

When navigating on //foo path :

On 2.9.2 :

On client :

On server :
Empty

On 2.11.0-pre.0 :

On client :

On server :
Empty

When navigating on /foo//bar path :

On 2.9.2 :

404 Not Found

On 2.11.0-pre.0 :

On client :

On server :

When navigating on //foo//bar path :

On 2.9.2 :

On client :

On server :

On 2.11.0-pre.0 :

On client :

On server :

[brophdawg11]

ah ok so this instance wasn't just from a url mismatch after all. I'll reopen and we can consider trying to detect and resolve this but I think I would recommend tackling this in user land for now and just redirecting prior to handling off the double-slash url to the Remix handler. Yolu could put this right before the remix handler in your express server:

  app.all("*", (req, res, next) => {
    if (req.path.includes('//')) {
      res.redirect(req.path.replace(/\/+/g, '/'));
    } else {
      next();
    }
  });

[github-actions]

🤖 Hello there,

We just published version 2.11.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!