Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Upgrade cloudflared #4126

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

gonzaloriestra
Copy link
Contributor

WHY are these changes introduced?

There were some tunneling issues lately and Cloudflare recommended to upgrade our binary

WHAT is this pull request doing?

Upgrade cloudflare to the latest version

How to test your changes?

p shopify app dev

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

Copy link
Contributor

github-actions bot commented Jun 26, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.62% 7478/10297
🟡 Branches 69.22% 3675/5309
🟡 Functions 71.59% 1976/2760
🟡 Lines 72.97% 7064/9681

Test suite run success

1720 tests passing in 794 suites.

Report generated by 🧪jest coverage report action from f9cd8fc

@gonzaloriestra gonzaloriestra merged commit 3bef8a5 into stable/3.63 Jun 26, 2024
@gonzaloriestra gonzaloriestra deleted the upgrade-cloudflared branch June 26, 2024 18:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants