Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accuracy #296

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Add accuracy #296

merged 4 commits into from
Nov 22, 2022

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Nov 21, 2022

Resolve #295

Description:

It adds a scrollbar in the performance table, but I think it is tolerable.
Screen Shot 2022-11-21 at 4 02 30 PM
Screen Shot 2022-11-21 at 4 02 41 PM

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma
Copy link
Contributor Author

gabegma commented Nov 21, 2022

Oups - I'll fix/edit the tests tomorrow.

Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! 👍

@JosephMarinier
Copy link
Contributor

Nothing new, but we could look into redesigning the metrics cards on the Prediction Overview as they are now way too wide to fit on the target MacBook Pro 14" by default.
Screen Shot 2022-11-22 at 2 25 07 PM
It's not tooooo bad as they still fit all fit if you close the Controls pannel:
image
Or if you use a MacBook Pro 16":
Screen Shot 2022-11-22 at 2 26 01 PM

@gabegma
Copy link
Contributor Author

gabegma commented Nov 22, 2022

Nothing new, but we could look into redesigning the metrics cards on the Prediction Overview as they are now way too wide to fit on the target MacBook Pro 14" by default.

Yeah, we could - at least the scrolling is quite nice when they don't fit.

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
@gabegma gabegma enabled auto-merge (squash) November 22, 2022 20:16
@gabegma gabegma merged commit c4b8675 into main Nov 22, 2022
@gabegma gabegma deleted the ggm/add-accuracy branch November 22, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add accuracy
2 participants