Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify F-E and B-E ports #286

Merged
merged 6 commits into from
Nov 4, 2022
Merged

Conversation

lindsaydbrin
Copy link
Contributor

Resolve # NA

Make it easier to simultaneously run multiple instances of Azimuth locally by passing port numbers in back-end and front-end commands.

Description:

Launch back-end with:

make CFG=<path_to_config> PORT=<backend_port_number> launch.local

(where PORT is optional)

Launch front-end with:

REACT_APP_BACKEND_PORT=<backend_port_number> PORT=<frontend_port_number> yarn start 

(where both PORT variables are optional, and backend_port_number should match the one for the back-end 🙃)

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

makefiles/Makefile.local Outdated Show resolved Hide resolved
@lindsaydbrin
Copy link
Contributor Author

@JosephMarinier I made it work without setting the default! I really wanted to be able to extract PORT_ARG into the poetry command as a naked command, but I couldn't figure that out and could only get the string in the command, so I ended up using eval and string concatenation. Feels less elegant, but it works. Do you have suggestions for anything more elegant?

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment, but that's good to go! 👍

Front-loaded the work to end the corrections

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
@lindsaydbrin lindsaydbrin marked this pull request as ready for review November 4, 2022 17:06
@lindsaydbrin lindsaydbrin enabled auto-merge (squash) November 4, 2022 17:07
@lindsaydbrin lindsaydbrin merged commit 9d48722 into main Nov 4, 2022
@lindsaydbrin lindsaydbrin deleted the lindsay/portportport branch November 4, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants