Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline pre/post-processing steps breakdown in the utterance detail page #263

Merged
merged 18 commits into from
Nov 15, 2022

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Oct 5, 2022

Resolve #283

Description:

  • For the documentation changes, I recommend looking at cdd8190 alone so you can see the diff.
  • I added a performance test so that it doesn't take too long to load the HF tables as we add columns to them, but I'm afraid that the tests will be a bit flaky. Not sure what is the best way to proceed and how much buffer to leave.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma force-pushed the ggm/pipeline-breakdown branch 10 times, most recently from 6e187d7 to 463ca2f Compare October 6, 2022 14:56
@gabegma gabegma marked this pull request as ready for review October 26, 2022 20:56
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small architecture question...

docs/docs/reference/custom-objects/processors.md Outdated Show resolved Hide resolved
azimuth/modules/model_contracts/text_classification.py Outdated Show resolved Hide resolved
azimuth/modules/model_contracts/text_classification.py Outdated Show resolved Hide resolved
azimuth/modules/model_contracts/text_classification.py Outdated Show resolved Hide resolved
ThresholdConfig(threshold=0.5),
]
)
] = Field([ThresholdConfig(threshold=0.5)], nullable=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the problem that @nandhinibsn has been experiencing; it was missing nullable=True. It's not related to this PR, but I committed it here to avoid conflicts: 7a053daa36f66f9cca442b04a1816a7821903153

gabegma and others added 3 commits November 14, 2022 11:37
@JosephMarinier JosephMarinier force-pushed the ggm/pipeline-breakdown branch 2 times, most recently from 6af5eb9 to 015b5a0 Compare November 14, 2022 16:45
@JosephMarinier
Copy link
Contributor

Hello @christyler3030, @nandhinibsn, could you please review my work on the front end? I recommend reviewing those 3 commits separately:

image

@JosephMarinier JosephMarinier changed the title First implementation of pipeline steps Pipeline steps Nov 14, 2022
@JosephMarinier JosephMarinier changed the title Pipeline steps Add pipeline pre/post-processing steps breakdown in the utterance detail page Nov 15, 2022
@JosephMarinier JosephMarinier enabled auto-merge (squash) November 15, 2022 19:12
@JosephMarinier JosephMarinier merged commit 96327e8 into main Nov 15, 2022
@JosephMarinier JosephMarinier deleted the ggm/pipeline-breakdown branch November 15, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the details of the preprocessing and postprocessing steps in the utterance details.
3 participants