You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I noticed we use the caret symbol ^ in front of the version for @senecacdot/satellite. Would it be better to use the exact version ("@senecacdot/satellite": "1.28.0") or continue using the almost version ("@senecacdot/satellite": "^1.28.0")?
I noticed we use the caret symbol ^ in front of the version for @senecacdot/satellite. Would it be better to use the exact version ("@senecacdot/satellite": "1.28.0") or continue using the almost version ("@senecacdot/satellite": "^1.28.0")?
The caret was added in #3050 so dependency bot could detect Satellite updates
I noticed we use the caret symbol ^ in front of the version for @senecacdot/satellite. Would it be better to use the exact version ("@senecacdot/satellite": "1.28.0") or continue using the almost version ("@senecacdot/satellite": "^1.28.0")?
The caret was added in #3050 so dependency bot could detect Satellite updates
Okay, so we like carets here. Speaking of dependency bot... I haven't seen Renovate bot in a while... did it leave us for another repo? Hmm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RC-Lee
added
area: elasticsearch
Issue This PR Addresses
Fixes #2913
Type of Change
Description
Updates ElasticSearch to 3.4.0 (from Satellite 1.28.0)
Notable changes -
Steps to test the PR
Built and works for me locally. Autocomplete also works.
Checklist