Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Satellite ES to 8.4.0, ES-mock to 2.0.0 #3676

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

RC-Lee
Copy link
Contributor

@RC-Lee RC-Lee commented Oct 5, 2022

Issue This PR Addresses

Part one of two for #2913

Type of Change

  • Dependency: Update a dependency

Description

We need to update and release ElasticSearch and ElasticSearch-Mock in Satellite before we can update it in Telescope.

Using 8.4.0, as it is the latest stable version on npm

Steps to test the PR

Please note
Telescope runs fine locally, all the docker containers will build, all the posts will show, and search will function as usual.
Satellite tests will pass.
However, Search tests will break, which is caused from ES-mock being very confused in our monorepo.
But, Search tests will work fine again once Telescope is using the new Satellite, with the new ES and ES-mock.

Checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not

@RC-Lee RC-Lee self-assigned this Oct 5, 2022
@gitpod-io
Copy link

gitpod-io bot commented Oct 5, 2022

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, assuming CI is happy, r+ from me. Thanks for maintaining this!

@RC-Lee
Copy link
Contributor Author

RC-Lee commented Oct 5, 2022

I just want to emphasize that Search tests are expected to break, cause ES-mock is very confused.
CI will be unhappy.
But it will be fixed once we use the new Satellite.

@humphd
Copy link
Contributor

humphd commented Oct 5, 2022

@RC-Lee apologies, I read that, and promptly wrote the opposite. Yes, break them here, fix in follow-up. Sounds good.

@RC-Lee RC-Lee merged commit 6e7a0a3 into Seneca-CDOT:master Oct 6, 2022
@RC-Lee RC-Lee deleted the Satellite-ES8.4.0 branch October 6, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: elasticsearch Elasticsearch Related issues and pull requests hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants