Add CONTRIBUTING.md #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work. I'll let others review this. I don't want to block all reviews on me, personally. It would be better if we distributed the review load across the community. |
Immutablevoid
approved these changes
Nov 5, 2019
aprilllllllll
approved these changes
Nov 5, 2019
aprilllllllll
approved these changes
Nov 5, 2019
|
@aprilllllllll Doesn't look like you have write access. @humphd Can you give @aprilllllllll write access to merge this pull request? |
|
@aprilllllllll have you accepted the invitation to become a collaborator? I sent it via GitHub. |
|
@humphd Yes I have accepted the invitation. Can I merge this PR now? |
|
@aprilllllllll for sure, do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27 .
This is clearly a work in progress. I will be working on finding better setup instructions, but for now this will work. I would really like feedback on how to approach issues and pull requests from the community, but what I have mirrors what I saw in other projects.
If there is anything I could add, or information I could use, please let me know. I would like to use docker, as that would simplify things greatly, and I know someone is working on it right now. I will update this as pull requests are merged and the system evolves.