Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to Environment Setup documentation #2930

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Fix link to Environment Setup documentation #2930

merged 2 commits into from
Feb 14, 2022

Conversation

JackyTea
Copy link
Contributor

@JackyTea JackyTea commented Feb 14, 2022

Noticed that Environment Setup documentation link was pointing to a markdown file that no longer exists.

Issue This PR Addresses

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Feb 14, 2022

sirinoks
sirinoks previously approved these changes Feb 14, 2022
JiaHua-Zou
JiaHua-Zou previously approved these changes Feb 14, 2022
TueeNguyen
TueeNguyen previously approved these changes Feb 14, 2022
Copy link
Contributor

@TueeNguyen TueeNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@cindyorangis cindyorangis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jacky!

Can you change the link to the relative link (../getting-started/environment-setup.md) instead of the (https://github.com/Seneca-CDOT/telescope/blob/master/src/docs/docs/getting-started/environment-setup.md)?

@TueeNguyen
Copy link
Contributor

@cindyledev I was wondering the same thing since the old one has absolute path

@JackyTea
Copy link
Contributor Author

Contributor

Changes made.

Copy link
Contributor

@cindyorangis cindyorangis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Welcome back to Telescope.

Noticed that `Environment Setup documentation` link was pointing to a markdown file that no longer exists.
@TueeNguyen
Copy link
Contributor

Let's rebase this @JackyTea and we're good to go

@tpmai22 tpmai22 merged commit 51dcf18 into Seneca-CDOT:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation (docs) Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants