Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build log should always show log #2840

Merged
merged 1 commit into from
Feb 5, 2022
Merged

fix: build log should always show log #2840

merged 1 commit into from
Feb 5, 2022

Conversation

Andrewnt219
Copy link
Contributor

Issue This PR Addresses

Closes #2818

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Changelog

  • Change after to sha in build-header

Steps to test the PR

Previously, the local can connect to staging for /deploy, but now it's CORS blocked. YOLO.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Feb 5, 2022

tpmai22
tpmai22 approved these changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@tpmai22 tpmai22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tcvan0707
Copy link
Contributor

Cool. Good work @Andrewnt219 ^^

cindyorangis
cindyorangis approved these changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@cindyorangis cindyorangis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@HyperTHD HyperTHD merged commit da1041d into Seneca-CDOT:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindyorangis cindyorangis cindyorangis approved these changes

@tpmai22 tpmai22 tpmai22 approved these changes

@tcvan0707 tcvan0707 tcvan0707 approved these changes

@humphd humphd Awaiting requested review from humphd

@JerryHue JerryHue Awaiting requested review from JerryHue

@Kevan-Y Kevan-Y Awaiting requested review from Kevan-Y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build log dashboard doesn't always show build log
5 participants
@Andrewnt219 @tcvan0707 @cindyorangis @tpmai22 @HyperTHD