-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported SnackBar component #1551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyvugithub
requested review from
humphd,
chrispinkney,
HyperTHD and
cindyorangis
January 18, 2021 01:25
chrispinkney
previously approved these changes
Jan 18, 2021
humphd
requested changes
Jan 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one typing thing.
tonyvugithub
force-pushed
the
next-issue1538
branch
from
January 18, 2021 02:35
2559172
to
388d96d
Compare
chrispinkney
previously approved these changes
Jan 18, 2021
humphd
previously approved these changes
Jan 18, 2021
tonyvugithub
dismissed stale reviews from humphd and chrispinkney
via
January 18, 2021 18:36
e176e14
tonyvugithub
force-pushed
the
next-issue1538
branch
from
January 18, 2021 18:36
388d96d
to
e176e14
Compare
tonyvugithub
force-pushed
the
next-issue1538
branch
from
January 18, 2021 18:51
e176e14
to
a6c5e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixed #1538
Type of Change
Description
I have modified the SnackBar component to be written in TS. I made some changes to the component to accompany using
handleClose
in the close button. TheonClose
property is not required because it is simply prevent us to close snackbar when we clickaway. Simply removeonClose
does the same thing.For reference, you can try what I mentioned above in this playground.
https://codesandbox.io/s/material-demo-forked-qe0kl?file=/demo.js
Checklist