Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1508: Port SEO from Gatsby to Nextjs #1509

Closed
wants to merge 2 commits into from
Closed

Fix #1508: Port SEO from Gatsby to Nextjs #1509

wants to merge 2 commits into from

Conversation

hyunjiLeeTech
Copy link
Contributor

Issue This PR Addresses

issue #1508

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI
  • Port: Port Gatsby to Nextjs

Description

Port SEO from Gatsby to Nextjs. The run test is not passed because currently, '../hooks/use-site-metadata' module is not there. Except this issue, test will be passed.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@hyunjiLeeTech hyunjiLeeTech changed the title Port SEO from Gatsby to Nextjs Fix #1508: Port SEO from Gatsby to Nextjs Dec 9, 2020
@hyunjiLeeTech hyunjiLeeTech self-assigned this Dec 9, 2020
@hyunjiLeeTech hyunjiLeeTech added area: front-end area: nextjs Nextjs related issues type: enhancement New feature or request labels Dec 9, 2020
@@ -0,0 +1,25 @@
import { FC } from 'react';
import Head from 'next/head';
import useSiteMetadata from '../hooks/use-site-metadata';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site-metadata hook isn't going to work as is, since it uses graphql to talk to Gatsby. We'll have to figure out a plan for passing data into next components from the build statically, maybe as env variables or maybe using static props. I know that others are thinking about this too.

@hyunjiLeeTech
Copy link
Contributor Author

I've checked the SEO.tsx file was not located in the correct folder. I moved the file into the /next/src/component folder. For the '../hook/use-site-metadata', I'm waiting somebody have done this part for the next :)

@tonyvugithub
Copy link
Contributor

@hyunjiLeeTech : Hi there, we are in the process of reviewing these migrated to Next PRs. Just wonder if you are still interested to work on this as we would like you to make some changes to your PR. Please let us know in case you decided to drop this then we can assign the issue to others. Thank you.

@chrispinkney
Copy link
Contributor

Closing due to #1566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end area: nextjs Nextjs related issues type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants