Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1470: Port SearchBar from Gatsby -> NextJS #1503

Closed
wants to merge 5 commits into from
Closed

Fix #1470: Port SearchBar from Gatsby -> NextJS #1503

wants to merge 5 commits into from

Conversation

MSTEWARDSON
Copy link
Contributor

Issue This PR Addresses

Fixes #1470

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Part of the Gatsby port to NextJS project. This PR handles the porting of the SearchBar component from Gatsby + JS to NextJS + TS. In general here is what has changed:

  • Removed unnecessary files
    - src/frontend/.cache
    - src/frontend/public
    - src/frontend/node_modules
  • Added "components" folder to contain the new SearchBar.tsx
  • Updated eslintrc.js to have a typescript plugin
  • Converted SearchBar component to NextJS
  • Installed missing packages in the next frontend

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@MSTEWARDSON
Updated my master to latest
cb7d975
@MSTEWARDSON
Ported SearchBar from Gatsby(js) -> NextJS(ts)
d8519a2 
- Removed unnecessary files

- Got props converted in SearchBar.tsx

- imported FC and setup it up for CustomizedInputBase

- added plugin typescript to the eslintrc.js
@MSTEWARDSON MSTEWARDSON added area: front-end area: nextjs Nextjs related issues labels Dec 7, 2020
@MSTEWARDSON MSTEWARDSON self-assigned this Dec 7, 2020
c3ho
c3ho requested changes Dec 7, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/frontend/next/src/components/SearchBar/SearchBar.tsx Outdated Show resolved Hide resolved
c3ho
c3ho reviewed Dec 7, 2020
View reviewed changes
src/frontend/next/package.json Outdated Show resolved Hide resolved
@MSTEWARDSON MSTEWARDSON requested a review from c3ho December 8, 2020 23:25
@tonyvugithub
Copy link
Contributor

@MSTEWARDSON : Hi there, we are in the process of reviewing these migrated to Next PRs. Just wonder if you are still interested to work on this as we would like you to make some changes to your PR. Please let us know in case you decided to drop this then we can assign the issue to others. Thank you.

@MSTEWARDSON
Copy link
Contributor Author

MSTEWARDSON commented Jan 16, 2021 •
edited
Loading

@tonyvugithub Hey, atm I'm quite busy. If someone else wants to take this over that's fine by me.

@tonyvugithub
Copy link
Contributor

@MSTEWARDSON : got it. Thanks

@humphd humphd added this to the 1.5 Release milestone Jan 19, 2021
@PedroFonsecaDEV PedroFonsecaDEV self-assigned this Jan 21, 2021
@PedroFonsecaDEV
Copy link
Contributor

Working on it.

@PedroFonsecaDEV PedroFonsecaDEV removed this from the 1.5 Release milestone Jan 21, 2021
@PedroFonsecaDEV
Copy link
Contributor

PedroFonsecaDEV commented Jan 21, 2021 •
edited
Loading

PR Fixes #1470 Port SearchBar to NEXT: #1581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd Awaiting requested review from humphd

@manekenpix manekenpix Awaiting requested review from manekenpix

@c3ho c3ho Awaiting requested review from c3ho

@HyperTHD HyperTHD Awaiting requested review from HyperTHD

@chrispinkney chrispinkney Awaiting requested review from chrispinkney

Assignees
No one assigned
Labels
area: front-end area: nextjs Nextjs related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[next] Port SearchBar from Gatsby to NextJS
6 participants
@MSTEWARDSON @tonyvugithub @PedroFonsecaDEV @c3ho @humphd @HyperTHD