Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #57: Adding TO-DOs into CONTRIBUTING.md #114

Merged
merged 5 commits into from
Nov 9, 2019
Merged

Fixes #57: Adding TO-DOs into CONTRIBUTING.md #114

merged 5 commits into from
Nov 9, 2019

Conversation

Immutablevoid
Copy link
Contributor

@Immutablevoid Immutablevoid commented Nov 9, 2019

Adding THE LIST OF THINGS THAT MUST BE DONE BY A CONTRIBUTOR BEFORE FILLING A PR.

@manekenpix manekenpix self-requested a review November 9, 2019 04:37
Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think package-lock.json shouldn't be here. Maybe you need to rebase?

@Immutablevoid
Copy link
Contributor Author

I think package-lock.json shouldn't be here. Maybe you need to rebase?

I did rebase. I could have been the npm install. Let me double check

@manekenpix manekenpix added the type: documentation (docs) Improvements or additions to documentation label Nov 9, 2019
@manekenpix manekenpix self-requested a review November 9, 2019 04:50
manekenpix
manekenpix previously approved these changes Nov 9, 2019
Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Immutablevoid
Copy link
Contributor Author

Immutablevoid commented Nov 9, 2019

I copied back the original package-lock.json.

From 181 additions and 80 deletions, back to 80 additions and 181 deletions.

It was probably because I called npm install, which I didn't really need to do since this was just editing documentation.

@Immutablevoid
Copy link
Contributor Author

Immutablevoid commented Nov 9, 2019

Sorry, I just wanted to be thorough so no one can mess up. Added another line to rerun the test after npm run eslint-fix

jatinAroraGit
jatinAroraGit previously approved these changes Nov 9, 2019
manekenpix
manekenpix previously approved these changes Nov 9, 2019
Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition! 👍

@Immutablevoid
Copy link
Contributor Author

I like the addition! 👍

WAIT, I'm sorry last one for sure. I made another typo 😢.

Copy link
Contributor

@ThomasLuu00 ThomasLuu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Immutablevoid Immutablevoid merged commit 5799a6f into Seneca-CDOT:master Nov 9, 2019
@Immutablevoid Immutablevoid deleted the issue57 branch November 9, 2019 05:20
@Immutablevoid Immutablevoid changed the title Fixes 57#: Adding TO-DOs into CONTRIBUTING.md Fixes #57: Adding TO-DOs into CONTRIBUTING.md Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation (docs) Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants