-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement (HTML/jS): modified the website #104
Conversation
CSS/HTML/JS updates for optimization of static webpage Fixes Seneca-CDOT#61 enhancement (folders): Front-End Folder made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Good job Sina.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks real good, well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is good, just add some code to avoid the horizontal scroll bar cause I think we don't need it.
|
||
} | ||
/* Regular Theme ends */ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the below code to avoid horizontal scroll.
html{
overflow-x: hidden;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overflow was supposed to be there for future mobile views, if this gets improved over the next week, then some more changes can be done 😄
@ODAVING this looks great man! |
Got it.
On Fri, Nov 8, 2019 at 4:15 PM Sina Lahsaee ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In planet.css
<#104 (comment)>:
> @@ -1,151 +1,241 @@
+/* Regular theme starts */
+.normalTheme{
+ --main-bg-color: #ffffff;
+ --nav-font-color: #b51418;
+ --box-shadow-color: rgba(221, 220, 220, 0.911);
+ --nav-btn-bgcolor: #ffffff;
+ --close-btn-hover: #d85f61;
+ --content-font: #000000;
+ --title-border: #a0a0a0d8;
+
+}
+/* Regular Theme ends */
+
The overflow was supposed to be there for future mobile views, if this
gets improved over the next week, then some more changes can be done 😄
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#104?email_source=notifications&email_token=ALKUOYKM7N4FRERMIKMLUT3QSXJH5A5CNFSM4JKTIWF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCK7FMXY#discussion_r344369481>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALKUOYIRL4UXTJUICCAWW5DQSXJH5ANCNFSM4JKTIWFQ>
.
--
Karla Chan/ Karlita
|
CSS/HTML/JS updates for optimization of static webpage
Fixes #61
If you'd like to preview the website, here it is: https://odaving.github.io/telescope/