Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update 3rd party license #5708

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Jun 21, 2024

This PR manually updates the 3rd party license.

The reason being that we needed to add an exception in licenses/additional_license_info.csv to fix the CI workflow for in-toto-golang package

@sakoush sakoush requested a review from lc525 as a code owner June 21, 2024 18:06
This was referenced Jun 21, 2024
@sakoush
Copy link
Member Author

sakoush commented Jun 21, 2024

@lc525 if you could have a quick sanity check at some on this manual update of 3rd party licenses that would be great.

@@ -118,3 +118,4 @@ https://github.com/smarty/assertions/blob/master/LICENSE.md,MIT License
https://github.com/hashicorp/consul/blob/main/LICENSE,Mozilla Public License 2.0
https://github.com/pelletier/go-toml/blob/v2/LICENSE,The MIT License (MIT)
https://github.com/SeldonIO/seldon-core/blob/v2/LICENSE,Business Source License 1.1
https://github.com/in-toto/in-toto-golang/blob/master/LICENSE,Apache License 2.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the reason of the manual change.

@sakoush sakoush added the v2 label Jun 24, 2024
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, manual change is correct

@sakoush sakoush merged commit d825d00 into SeldonIO:v2 Jun 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants