fix(deps): major version updates in /scheduler/data-flow #5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump kotlin language version 1.8.20 -> 1.9.21 - bump kotlinx-coroutines-core 1.7.3 -> 1.8.1 - bump io.grpc:grpc-* 1.63.0 -> 1.64.0 The only remaining update that we would like to make to dataflow is bumping JDK 17 -> JDK 21. However, that update is currently blocked by the requirements of kafka-streams; The confluent platform libraries that we're using (kafka-streams:7.6.1-ccs) have only been tested up to JDK 17 according to: https://docs.confluent.io/platform/current/installation/versions-interoperability.html#java
lc525
changed the title
sakoush
approved these changes
May 24, 2024
| @@ -10,14 +10,15 @@ the Change License after the Change Date as each is defined in accordance with t | |||
| package io.seldon.dataflow | |||
|
|
|||
| import kotlinx.coroutines.CoroutineScope | |||
| import kotlinx.coroutines.ExperimentalCoroutinesApi | |||
There was a problem hiding this comment.
question: curious what is this adding?
There was a problem hiding this comment.
Some parallel operations on Flows (i.e parallel processing of elements in a flow, like the one we want to do for pipelines) are marked as experimental, with semantics that might change. We have a test that uses some of those to see how they behave.
There was a problem hiding this comment.
Functions calling those experimental operations just need to be marked with the ExperimentalCoroutinesApi decorator in order to avoid a compiler warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only remaining update that we would like to make to dataflow is bumping JDK 17 -> JDK 21. However, that update is currently blocked by the requirements of kafka-streams; The confluent platform libraries that we're using (kafka-streams:7.6.1-ccs) have only been tested up to JDK 17 according to: https://docs.confluent.io/platform/current/installation/versions-interoperability.html#java
Which issue(s) this PR fixes:
Special notes for your reviewer: