Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dataflow): Add ktlint plugin in Gradle, run formatter, and fix lint issues #5491

Merged
merged 19 commits into from
Apr 4, 2024

Conversation

KengoA
Copy link
Contributor

@KengoA KengoA commented Apr 3, 2024

What this PR does / why we need it:

Currently the dataflow engine has no form of linting or formatting whatsoever. This PR:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@KengoA KengoA marked this pull request as ready for review April 3, 2024 17:19
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm,

Is linting running in the CI as well? If not please add it.

@KengoA
Copy link
Contributor Author

KengoA commented Apr 3, 2024

Is linting running in the CI as well?

Yes I added an extra lint step here:

- name: lint-dataflow

Runs the worfklow here successfully: https://github.com/SeldonIO/seldon-core/actions/runs/8543232746/job/23406587633?pr=5491

@KengoA KengoA merged commit 89510c3 into SeldonIO:v2 Apr 4, 2024
2 checks passed
@KengoA KengoA added the v2 label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants