fix(dataflow): Do not skip events to remove old pipeline versions #5469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5080 there is a change to skip events coming from
chainer-server
, this essentially has stopped the flow of removing old version of pipelines during a rolling update. The reason being is that the logic that triggers the removal of old versions of the pipeline (here) is eventually coming from setting the status of the new version of the pipeline from an event sent from the chainer-server.This PR then makes the change to not set the source of the events for deleting old version and therefore they can be processed further by chainer
handlePipelineEvent
.This seems not very intuitive but I am not sure if there is a better way at the minute without a big refactor.