fix(adserver): adserver returns cloudevents compatible response #5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ | |||
| SELDON_PREDICTOR_ID = DEFAULT_LABELS["predictor_name"] | |||
|
|
|||
|
|
|||
| def _load_class_module(module_path: str) -> str: | |||
| def _load_class_module(module_path: str): | |||
There was a problem hiding this comment.
Why? It still seems to return str, or not?
There was a problem hiding this comment.
It actually returns a Module. It was raising type hint warnings because it's used like so in L77-79
# Load from locally available models
MetricsClass = _load_class_module(self.storage_uri)
self.model = MetricsClass()There was a problem hiding this comment.
so potentially -> "Module" (or other appropriate way to annotate the return type) could be good?
There was a problem hiding this comment.
probably you'd need to import appropriate type
majolo
approved these changes
Feb 19, 2024
|
@michaelcheah please mark as |
michaelcheah
deleted the
adserver-returns-cloudevents-compatible-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
adserveris meant to be deployed as a knative serving service. However, it is currently not setting the appropriate headers in its http response in the POST handler for the response to be considered a CloudEvent message. As can be seen by the spec, the following attributes must be present in the http message:Previously, none of these attributes were set in the response (though they were set when the message was forwarded to the
replyUrl)This PR does the following:
test_server.pyfile to check that responses are CE compatible