fix: Connection retries when scheduler restarts for dataflow and controller #5292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
changed the title
sakoush
changed the title
sakoush
changed the title
lc525
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
I had a question regarding whether grpc.Dial on line 218 will stop retrying or not retry on certain errors. I'm still looking at grpc_retry to understand the exact behaviour
| func (s *SchedulerClient) startEventHanders(namespace string, conn *grpc.ClientConn) { | ||
| retryFn := func(fn func(context context.Context, conn *grpc.ClientConn) error, context context.Context, conn *grpc.ClientConn) error { | ||
| logFailure := func(err error, delay time.Duration) { | ||
| s.logger.Error(err, "Scheduler not ready") |
There was a problem hiding this comment.
One of the issues here is that we'll probably be seeing each error 4 times when the scheduler is down (once from each of the coroutines below), but I'm not sure if we can sort that out easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In some cases during testing,
dataflow-enginedidnt reconnect to the new scheduler pod after a rolling update. Thecontrolleralso suffers from the same issue. The fix is to retry (for now indefinitely) which is the same pattern used inagent(link),model-gateway(link) andpipeline-gateway(link).Summary of changes:
subscribePipelines(dataflow)startEventHanders(controller)Which issue(s) this PR fixes:
Fixes INFRA-713 (internal)
Special notes for your reviewer: