ci(security): Remove linting steps from GHA security workflow #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Motivation
Currently, the security workflow for GitHub Actions has steps that perform linting for the
scheduler/andoperator/directories. The setup for this is not the same as for the linting action for PRs. As a result, it seems that while the PR workflows succeed, the security tests can fail on linting.There is no need for these to perform linting in any case, precisely because this is done for every PR, so all the code merged into the
v2branch already meets linting requirements. Removing this additional step is therefore removing redundancy and also removing a source of inconsistency.The inclusion of linting was questioned originally and included simply because it's what Core v1 does. I firmly believe this is redundant and can safely be removed.
What
Changes
Testing
N/A