Return the OOF instances for classifier-based drift detectors (ClassifierDrift and SpotTheDiffDrift) #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jklaise
reviewed
Oct 24, 2022
jklaise
reviewed
Oct 24, 2022
jklaise
reviewed
Oct 24, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 79.09% 79.12% +0.02%
==========================================
Files 126 126
Lines 8870 8895 +25
==========================================
+ Hits 7016 7038 +22
- Misses 1854 1857 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jklaise
reviewed
Oct 25, 2022
jklaise
approved these changes
Oct 25, 2022
ascillitoe
pushed a commit
that referenced
this pull request
Nov 8, 2022
…fierDrift and SpotTheDiffDrift) (#665) * add out-of-fold instances to the return dict for classifier detectors * update docs * update score return type * fix typo and mypy error * extend to list inputs and update score return types * add Union import * fix type error * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the ClassifierDrift or SpotTheDiffDrift detectors, you can return the prediction probabilities on the out-of-fold instances. However, when you use
train_sizeinstead of cross-validation, you don't know which instances these probabilities correspond to, since you don't know which reference and test instances are used for training or prediction. This PR adds the associated reference and test instances to the detector's return dictionary.