-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added model_kwargs to huggingface model #1417
Conversation
@adriangonz ,could you review it when you have a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @nanbo-liu! This would be a great addition to the HF runtime - thanks for contributing it 🚀
Changes look good - although, could you add some tests to validate that the model kwargs get used? Once tests are in, we should be good to land this one. 👍
@adriangonz ,added unit tests from the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant! Thanks for the changes @nanbo-liu !
This should be good to go now 🚀
@adriangonz ,I rewrite the unit test a little bit. The previous version depends on package |
@adriangonz, just fixed the unit test bug. would you try again |
@adriangonz ,CICD keeps getting runtime error for |
Yuuup, it seems there's an unrelated error in the |
This is for issue 1344
This allow
model-settings.json
to takemodel_kwargs
:example below: