-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved huggingface batch logic #1336
Improved huggingface batch logic #1336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! Thanks for taking the time to contribute this patch @ajsalow.
Before merging, could you add a test covering the new behaviour? Besides that, there also seem to be some conflicts with latest master
.
Thanks for taking a look @adriangonz. I've added some test coverage, let me know if anything else is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding that test @ajsalow 👍
Once tests are green, we should be able to merge this one.
Hey @ajsalow , Just had a look at the test failures. I think from those, the
|
@adriangonz apologies, I incorrectly assumed linting was using pylint. |
Addresses issues described in #1249 where batch size greater than 0 causes some hugging face models to fail loading.