Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent logging #1230

Merged
merged 17 commits into from
Jun 15, 2023
Merged

Silent logging #1230

merged 17 commits into from
Jun 15, 2023

Conversation

dtpryce
Copy link
Contributor

@dtpryce dtpryce commented Jun 14, 2023

  • Removed the v option from tar
  • Sent output of activate to dev/null

Was hard to test with the mlserver image being built elsewhere

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @dtpryce! Added a small comment there, but the approach make sense 👍

hack/activate-env.sh Outdated Show resolved Hide resolved
@dtpryce dtpryce requested a review from adriangonz June 14, 2023 13:13
@dtpryce
Copy link
Contributor Author

dtpryce commented Jun 14, 2023

Awesome @adriangonz feel free to merge into 1.4.0 or earlier :P

@dtpryce
Copy link
Contributor Author

dtpryce commented Jun 14, 2023

Awesome @adriangonz feel free to merge into 1.4.0 or earlier :P

Actually wait I have another small update for it

@adriangonz
Copy link
Contributor

Nice one! This should be ready to go. Thanks for the changes @dtpryce ! 🚀

@adriangonz adriangonz merged commit 58c52b9 into SeldonIO:master Jun 15, 2023
adriangonz pushed a commit that referenced this pull request Jun 16, 2023
@Kolajik Kolajik mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants