fix(admin editor): only use Sefaria.normRef() which also does encodeU…

…RIComponent()
Sefaria · Jun 24, 2024 · c4b08ce · c4b08ce
1 parent eb396e2
commit c4b08ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/static/js/SourceEditor.jsx b/static/js/SourceEditor.jsx
@@ -92,7 +92,7 @@ const SourceEditor = ({topic, close, origData={}}) => {
     }
 
     const deleteTopicSource = function() {
-        const url = `/api/ref-topic-links/${encodeURIComponent(origData.ref)}?topic=${topic}&interface_lang=${Sefaria.interfaceLang}`;
+        const url = `/api/ref-topic-links/${Sefaria.normRef(origData.ref)}?topic=${topic}&interface_lang=${Sefaria.interfaceLang}`;
         Sefaria.adminEditorApiRequest(url, null, null, "DELETE")
             .then(() => window.location.href = `/topics/${topic}`);
     }

diff --git a/static/js/sefaria/sefaria.js b/static/js/sefaria/sefaria.js
@@ -630,7 +630,7 @@ Sefaria = extend(Sefaria, {
       return await Sefaria.apiRequestWithBody(`/api/subscribe/steinsaltz/${email}`, null, payload);
   },
   postRefTopicLink: function(refInUrl, payload) {
-      const url = `/api/ref-topic-links/${encodeURIComponent(Sefaria.normRef(refInUrl))}`;
+      const url = `/api/ref-topic-links/${Sefaria.normRef(refInUrl)}`;
       // payload will need to be refactored once /api/ref-topic-links takes a more standard input
       return Sefaria.adminEditorApiRequest(url, null, payload);
   },