Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propar ar plural form #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abdallah-abdelfatah
Copy link

I was recently working on some changes on maple/horizontal FE changes, and I notice that we're using our fork of humanize duration. But it's lacking the proper plural rules for AR as per language plural rules, I can also confirm that's correct since it's my own language. : ))

upon further investigation, it turns out that this change was done to original repo, check getArabicForm function here.

This pr is cpying the minimal changes for the proper plural form in AR, it's missing some stuff of things (tests) but I went with this quick and dirty way to see if I should but more time in this.

This is currently in my own fork, I'll either keep it or move depending on the maintainer decision.

So let me know,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant