Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade target api and dependencies #129

Merged
merged 21 commits into from
Jan 2, 2024

Conversation

morckx
Copy link
Collaborator

@morckx morckx commented Nov 5, 2023

  • Updates to latest privacy-friendly-backup-api v1.3.0
  • Bumps compile & target SDK from 32 to 34
  • Updates Gradle from 7.3.3 to 8.4
  • Updates Gradle plugin from 7.2.2 to 8.2.0
  • Updates Java form 11 to 17
  • Updates all dependencies
  • Uses ACTION_CREATE_DOCUMENT intent action to export CSV data on APIs >=19
  • Uses RequestMultiplePermissions API to acquire runtime permissions.
  • Moves runtime permission requests to last tutorial page
  • Returns from setting to main activity on first app use
  • Fixes potential broadcast information leak

@morckx
Copy link
Collaborator Author

morckx commented Nov 14, 2023

CSV export on API 34 still needs to be fixed.

According to API 34 logs this seems advisable.
To avoid permission not granted exceptions on API when app is started
for the first time.
app/src/main/java/org/secuso/privacyfriendlyactivitytracker/activities/MainActivity.java
Fixes potential privacy leak and lint error:

/home/runner/work/privacy-friendly-pedometer/privacy-friendly-pedometer/app/src/main/java/org/secuso/privacyfriendlyactivitytracker/persistence/WalkingModePersistenceHelper.java:152:
Error: The intent action
org.secuso.privacyfriendlystepcounter.WALKING_MODE_CHANGED (used to send
a broadcast) matches the intent filter of a non-exported component
org.secuso.privacyfriendlyactivitytracker.receivers.StepCountPersistenceReceiver
from a manifest. If you are trying to invoke this specific component via
the action then you should make the intent explicit by calling
Intent.set{Component,Class,ClassName}. [UnsafeImplicitIntentLaunch]
Intent localIntent = new
Intent(BROADCAST_ACTION_WALKING_MODE_CHANGED);
@morckx morckx merged commit b8b6ad4 into SecUSo:master Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants