Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maxiv pipeline trigger and clean up unused files #981

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

nguyenlinhlinh
Copy link
Contributor

Description

Short description of the pull request

Motivation

Background on use case, changes needed

Fixes:

  • Items added

Changes:

  • changes made

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?
  • Requires update of SciCat backend API?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2878245856

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.9%) to 73.97%

Files with Coverage Reduction New Missed Lines %
src/app/datasets/admin-tab/admin-tab.component.ts 2 30.95%
src/app/datasets/dataset-lifecycle/dataset-lifecycle.component.ts 2 79.41%
src/app/datasets/dataset-detail/dataset-detail.component.ts 5 80.37%
src/app/datasets/reduce/reduce.component.ts 6 38.36%
src/app/datasets/dataset-details-dashboard/dataset-details-dashboard.component.ts 10 31.85%
Totals Coverage Status
Change from base Build 2861367528: -0.9%
Covered Lines: 3648
Relevant Lines: 4528

💛 - Coveralls

@nguyenlinhlinh nguyenlinhlinh merged commit 5821b21 into master Aug 18, 2022
@nguyenlinhlinh nguyenlinhlinh deleted the maxiv-cleanup branch August 18, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants