-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link raw derived datasets #976
Conversation
src/app/datasets/related-datasets/related-datasets.component.ts
Outdated
Show resolved
Hide resolved
@nguyenlinhlinh I can't seem to get this component to play nicely with the lazy loading. If you have any suggestions on how to fix the things above, please let me know. The problem seems to be that all the actions to fetch and clear state data are done in the dataset-details-component, but since you never actually leave that component when switching between the tabs, or go to related dataset, the state doesn't change. |
@henrikjohansson712 I will take a look into it and let you know if I figure it out. |
@nguyenlinhlinh I've added a service to help with reloading the data in the view. Let me know what you think. |
src/app/datasets/dataset-details-dashboard/dataset-details-dashboard.component.ts
Outdated
Show resolved
Hide resolved
src/app/datasets/related-datasets/related-datasets.component.ts
Outdated
Show resolved
Hide resolved
@henrikjohansson712 Thank you for making the changes. Sorry, I tried the user interface and the data still doesn't update properly for some tabs. I think we need to also clear the attachment, (maybe also the reducer and logbook, I am not sure) and originblocks (for datafiles). Btw, what day is your last day? |
@nguyenlinhlinh My last day is Friday this week. Not sure how much time I'll have to work on this PR. |
@henrikjohansson712 I see. If you dont have time to work on it I can pick it up after you have left. |
This PR is ready for review again. I have fixed the data caching problem. Now when user click on dataset in Related dataset tab the dataset detail should be update correctly. @nitrosx, please try this out. |
Tested and working |
Description
Add a new tab to dataset details view, that contains a table showing all related datasets for the current datasets.
Motivation
See issue #932
Fixes:
Changes:
Tests included/Docs Updated?