Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link raw derived datasets #976

Merged
merged 37 commits into from
Aug 15, 2022
Merged

Link raw derived datasets #976

merged 37 commits into from
Aug 15, 2022

Conversation

henrikjohansson712
Copy link
Contributor

Description

Add a new tab to dataset details view, that contains a table showing all related datasets for the current datasets.

Motivation

See issue #932

Fixes:

Changes:

  • Add new related datasets component
  • Set up lazy loading of new component

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?
  • Requires update of SciCat backend API?

@coveralls
Copy link

coveralls commented Jun 16, 2022

Pull Request Test Coverage Report for Build 2697376747

  • 61 of 77 (79.22%) changed or added relevant lines in 5 files are covered.
  • 51 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+1.2%) to 74.51%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/datasets/related-datasets/related-datasets.component.ts 15 16 93.75%
src/app/datasets/dataset-details-dashboard/dataset-details-dashboard.component.ts 3 5 60.0%
src/app/state-management/reducers/datasets.reducer.ts 22 28 78.57%
src/app/state-management/effects/datasets.effects.ts 15 22 68.18%
Files with Coverage Reduction New Missed Lines %
src/app/datasets/archiving.service.ts 2 48.39%
src/app/datasets/dashboard/dashboard.component.ts 2 77.55%
src/app/datasets/dataset-file-uploader/dataset-file-uploader.component.ts 2 79.49%
src/app/datasets/dataset-detail/dataset-detail.component.ts 3 82.21%
src/app/jobs/jobs-dashboard/jobs-dashboard.component.ts 4 50.65%
src/app/state-management/reducers/datasets.reducer.ts 9 78.23%
src/app/state-management/effects/datasets.effects.ts 12 71.85%
src/app/datasets/dataset-details-dashboard/dataset-details-dashboard.component.ts 17 47.41%
Totals Coverage Status
Change from base Build 2473833424: 1.2%
Covered Lines: 3658
Relevant Lines: 4528

💛 - Coveralls

@henrikjohansson712
Copy link
Contributor Author

henrikjohansson712 commented Jun 23, 2022

@nguyenlinhlinh I can't seem to get this component to play nicely with the lazy loading. If you have any suggestions on how to fix the things above, please let me know.

The problem seems to be that all the actions to fetch and clear state data are done in the dataset-details-component, but since you never actually leave that component when switching between the tabs, or go to related dataset, the state doesn't change.

@nguyenlinhlinh
Copy link
Contributor

@henrikjohansson712 I will take a look into it and let you know if I figure it out.

@henrikjohansson712
Copy link
Contributor Author

@nguyenlinhlinh I've added a service to help with reloading the data in the view. Let me know what you think.

@nguyenlinhlinh
Copy link
Contributor

@henrikjohansson712 Thank you for making the changes. Sorry, I tried the user interface and the data still doesn't update properly for some tabs. I think we need to also clear the attachment, (maybe also the reducer and logbook, I am not sure) and originblocks (for datafiles). Btw, what day is your last day?

@henrikjohansson712
Copy link
Contributor Author

@nguyenlinhlinh My last day is Friday this week. Not sure how much time I'll have to work on this PR.

@nguyenlinhlinh
Copy link
Contributor

@henrikjohansson712 I see. If you dont have time to work on it I can pick it up after you have left.

@nguyenlinhlinh
Copy link
Contributor

This PR is ready for review again. I have fixed the data caching problem. Now when user click on dataset in Related dataset tab the dataset detail should be update correctly. @nitrosx, please try this out.

@nitrosx
Copy link
Contributor

nitrosx commented Aug 15, 2022

Tested and working

@nitrosx nitrosx merged commit fa64382 into master Aug 15, 2022
@nitrosx nitrosx deleted the link-raw-derived-datasets branch August 15, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: navigate from Raw Dataset to its Derived Datasets
4 participants