changed permissions to make dataset public according to new casl model #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allow to make a dataset public to any user who is an admin or is part of the group that owns the dataset.
Motivation
The current frontend is still following the old backend permission model and allows to publish a dataset only the user which email is listed as PI (which in the new BE we do not use this field as such) or the user named admin.
With BE 4.x admin users can be configured and the user name does not indicate if it is an admin or not. Also, any user that belongs to the group listed as dataset owner should be able to make such change.
Changes:
Tests included/Docs Updated?