Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: thumbnail fetch error on OIDC logout #1060

Merged
merged 4 commits into from
May 17, 2023

Conversation

Junjiequan
Copy link
Contributor

Description

on logout only fetch isPublished:true datasets' thumbnails

Motivation

when logout if current page includes not published datasets it throw thumbnail fetch fail errors

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?
  • Requires update of SciCat backend API?

@Junjiequan Junjiequan requested a review from nitrosx May 16, 2023 19:07
@Junjiequan Junjiequan merged commit ab39cd6 into master May 17, 2023
@Junjiequan Junjiequan deleted the SWAP-3240-scicat-be-logout-404-or-401-error branch May 17, 2023 11:49
fpotier pushed a commit that referenced this pull request Jan 15, 2024
* fix: thumbnail fetch error on OIDC logout

* fix: minor naming convention change

* fix: follow variable naming convention

---------

Co-authored-by: Max Novelli <Max.Novelli@ess.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants