Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove customMetadata from instruments dashboard & include uniqu… #1053

Merged

Conversation

Junjiequan
Copy link
Contributor

@Junjiequan Junjiequan commented Apr 27, 2023

…e name

Description

Replaced custom metadata column with unique name column on instruments dashboard page and also included unique name on instrument detail page & dataset detail page

Motivation

Given that multiple identical instrument name can exist at the same time, it is needed to provide user unique identifier for the specific instrument.

Changes:

Screenshot 2023-04-27 at 15 28 41
Screenshot 2023-04-27 at 15 28 50
Screenshot 2023-04-27 at 15 29 05

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?
  • Requires update of SciCat backend API?

@Junjiequan Junjiequan requested a review from nitrosx April 27, 2023 13:41
@Junjiequan Junjiequan self-assigned this Apr 27, 2023
@nitrosx nitrosx merged commit 6ad76c5 into master Apr 28, 2023
@nitrosx nitrosx deleted the SWAP-3242-scicat-fe-add-instrument-unique-name-if-present-i branch April 28, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants