Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: user logout button not working #1017

Merged
merged 6 commits into from
Jan 11, 2023
Merged

Fix: user logout button not working #1017

merged 6 commits into from
Jan 11, 2023

Conversation

Junjiequan
Copy link
Contributor

@Junjiequan Junjiequan commented Jan 10, 2023

Description

  • fixed logout button not working
  • fixed user token text breakout container issue
  • covered e2e test for logout

and prettier or linter fixed some indentation automatically.

Changes:

cypress/integration/users-login.spec.js
src/app/_layout/app-header/app-header.component.html
src/app/_layout/app-header/app-header.component.ts
src/app/state-management/actions/user.actions.ts
src/app/users/user-settings/user-settings.component.scss

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?
  • Requires update of SciCat backend API?

Copy link
Contributor

@jekabs-karklins jekabs-karklins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Junjiequan Junjiequan merged commit de98719 into SciCatProject:master Jan 11, 2023
@Junjiequan Junjiequan deleted the SWAP-2977-logout-button-on-scicat-does-not-work branch January 11, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants