Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow help messages configuration from config.json #1000

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Allow help messages configuration from config.json #1000

merged 1 commit into from
Nov 22, 2022

Conversation

minottic
Copy link
Contributor

@minottic minottic commented Nov 22, 2022 •
edited
Loading

Description

It allows to set the some custom messages in the helper

Motivation

At PSI we need to put a note stating that some links only work internally

Changes:

  • add help message class to config
  • retrieve messages from config in help component
  • add tests

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?
  • Requires update of SciCat backend API?

@minottic minottic merged commit 934bef1 into master Nov 22, 2022
@minottic minottic deleted the help_messages branch November 22, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephan271 stephan271 stephan271 approved these changes

@nitrosx nitrosx Awaiting requested review from nitrosx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minottic @stephan271