Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#274) - refactor signupscreen #275

Merged
merged 10 commits into from
Aug 20, 2024

Conversation

audgns10
Copy link
Member

@audgns10 audgns10 commented Aug 19, 2024

๐Ÿ’ก ๊ฐœ์š”

  • SignUpScreen์˜ ๋ž˜ํŒฉํ† ๋ง ์ž‘์—…์ด ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • SignUpScreen์„ ๋ฆฌํŒฉํ† ๋ง ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ์ปดํฌ์ €๋ธ”์—์„œ ๊ด€๋ฆฌ๊ฐ€ ๋˜๊ณ  ์žˆ๋Š” ์ƒํƒœ๋ฅผ viewModel๋กœ ์˜ฎ๊ฒจ์„œ SavedStateHandle๋กœ ์ฒ˜๋ฆฌ๋ฅผ ํ•ฉ๋‹ˆ๋‹ค
    • by ํ‚ค์›Œ๋“œ๋ฅผ ์‚ฌ์šฉํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ์ƒํƒœ ํ˜ธ์ด์ŠคํŒ…์„ ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ๊ตฌ์กฐ ๋ถ„ํ•ด ์„ ์–ธ์„ ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ํ•œ ํŒŒ์ผ์— ๋ชฐ๋ ค์žˆ๋Š” ๊ฒƒ ๊ฐ™์•„ util ํŒจํ‚ค์ง€ ์•ˆ์œผ๋กœ ๋ถ„๋ฆฌ๋ฅผ ํ•ด์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค(keyboardAsState, Enum Class . . .)
    • ์ฝ”๋“œ๋ฅผ ๊ฐ„์†Œํ™”ํ•ฉ๋‹ˆ๋‹ค
    • modifier ์ธ์ž๋กœ ๋ฐ›์„ ์ˆ˜ ์žˆ๋„๋ก ์ฝ”๋“œ ์ปจ๋ฒค์…˜์„ ๋งž์ถฅ๋‹ˆ๋‹ค

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • refactor SignUpScreen
  • refactor SignUpViewModel\
  • add KeyboardAsState
  • add SignUpState(Enum)
  • add Keyboard(Enum)

๐Ÿ™‹โ€โ™‚๏ธ ์งˆ๋ฌธ์‚ฌํ•ญ

  • ์ด์ƒํ•œ ๋ถ€๋ถ„์ด ์žˆ๋‹ค๋ฉด comment๋กœ ๊ณต๊ฒฉํ•ด์ฃผ์„ธ์š”!

@audgns10 audgns10 changed the title :ใ……ใ…ˆ274 refactor signupscreen ๐Ÿ”€ :: (#274) - refactor signupscreen Aug 19, 2024
@audgns10 audgns10 self-assigned this Aug 19, 2024
@audgns10 audgns10 added 2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ - ์ค‘ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง labels Aug 19, 2024
@audgns10 audgns10 merged commit 1a586a1 into develop Aug 20, 2024
1 check passed
@audgns10 audgns10 deleted the refactor/274-refactor-signupscreen branch August 20, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ - ์ค‘ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
4 participants