Merge tag 'v3.46.0' into sc

* Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\matrix-org#7790](matrix-org#7790)). Contributed by @johannes-krude. * Live location sharing - open location in OpenStreetMap ([\matrix-org#8695](matrix-org#8695)). Contributed by @kerryarchibald. * Show a dialog when Jitsi encounters an error ([\matrix-org#8701](matrix-org#8701)). Fixes element-hq/element-web#22284. * Add support for setting the `avatar_url` of widgets by integration managers. ([\matrix-org#8550](matrix-org#8550)). Contributed by @Fox32. * Add an option to ignore (block) a user when reporting their events ([\matrix-org#8471](matrix-org#8471)). * Add the option to disable hardware acceleration ([\matrix-org#8655](matrix-org#8655)). Contributed by @novocaine. * Slightly better presentation of read receipts to screen reader users ([\matrix-org#8662](matrix-org#8662)). Fixes element-hq/element-web#22293. Contributed by @pvagner. * Add jump to related event context menu item ([\matrix-org#6775](matrix-org#6775)). Fixes element-hq/element-web#19883. * Add public room directory hook ([\matrix-org#8626](matrix-org#8626)). * Remove inline margin from UTD error message inside a reply tile on ThreadView ([\matrix-org#8708](matrix-org#8708)). Fixes element-hq/element-web#22376. Contributed by @luixxiul. * Move unread notification dots of the threads list to the expected position ([\matrix-org#8700](matrix-org#8700)). Fixes element-hq/element-web#22350. Contributed by @luixxiul. * Prevent overflow of grid items on a bubble with UTD generally ([\matrix-org#8697](matrix-org#8697)). Contributed by @luixxiul. * Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\matrix-org#8704](matrix-org#8704)). Fixes element-hq/element-web#22365. Contributed by @luixxiul. * Fix - AccessibleButton does not set disabled attribute ([\matrix-org#8682](matrix-org#8682)). Contributed by @kerryarchibald. * Fix font not resetting when logging out ([\matrix-org#8670](matrix-org#8670)). Fixes element-hq/element-web#17228. * Fix local aliases section of room settings not working for some homeservers (ie ([\matrix-org#8698](matrix-org#8698)). Fixes element-hq/element-web#22337. * Align EventTile_line with display name on message bubble ([\matrix-org#8692](matrix-org#8692)). Fixes element-hq/element-web#22343. Contributed by @luixxiul. * Convert references to direct chat -> direct message ([\matrix-org#8694](matrix-org#8694)). Contributed by @novocaine. * Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\matrix-org#8687](matrix-org#8687)). * Make the empty thread panel fill BaseCard ([\matrix-org#8690](matrix-org#8690)). Fixes element-hq/element-web#22338. Contributed by @luixxiul. * Fix edge case around composer handling gendered facepalm emoji ([\matrix-org#8686](matrix-org#8686)). * Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\matrix-org#8688](matrix-org#8688)). Fixes element-hq/element-web#21914. Contributed by @luixxiul. * Apply the same max-width to image tile on the thread timeline as message bubble ([\matrix-org#8669](matrix-org#8669)). Fixes element-hq/element-web#22313. Contributed by @luixxiul. * Fix dropdown button size for picture-in-picture CallView ([\matrix-org#8680](matrix-org#8680)). Fixes element-hq/element-web#22316. Contributed by @luixxiul. * Live location sharing - fix square border for image-less avatar (PSF-1052) ([\matrix-org#8679](matrix-org#8679)). Contributed by @kerryarchibald. * Stop connecting to a video room if the widget messaging disappears ([\matrix-org#8660](matrix-org#8660)). * Fix file button and audio player overflowing from message bubble ([\matrix-org#8666](matrix-org#8666)). Fixes element-hq/element-web#22308. Contributed by @luixxiul. * Don't show broken composer format bar when selection is whitespace ([\matrix-org#8673](matrix-org#8673)). Fixes element-hq/element-web#10788. * Fix media upload http 413 handling ([\matrix-org#8674](matrix-org#8674)). * Fix emoji picker for editing thread responses ([\matrix-org#8671](matrix-org#8671)). Fixes matrix-org/element-web-rageshakes#13129. * Map attribution while sharing live location is now visible ([\matrix-org#8621](matrix-org#8621)). Fixes element-hq/element-web#22236. Contributed by @weeman1337. * Fix info tile overlapping the time stamp on TimelineCard ([\matrix-org#8639](matrix-org#8639)). Fixes element-hq/element-web#22256. Contributed by @luixxiul. * Fix position of wide images on IRC / modern layout ([\matrix-org#8667](matrix-org#8667)). Fixes element-hq/element-web#22309. Contributed by @luixxiul. * Fix other user's displayName being wrapped on the bubble message layout ([\matrix-org#8456](matrix-org#8456)). Fixes element-hq/element-web#22004. Contributed by @luixxiul. * Set spacing declarations to elements in mx_EventTile_mediaLine ([\matrix-org#8665](matrix-org#8665)). Fixes element-hq/element-web#22307. Contributed by @luixxiul. * Fix wide image overflowing from the thumbnail container ([\matrix-org#8663](matrix-org#8663)). Fixes element-hq/element-web#22303. Contributed by @luixxiul. * Fix styles of "Show all" link button on ReactionsRow ([\matrix-org#8658](matrix-org#8658)). Fixes element-hq/element-web#22300. Contributed by @luixxiul. * Automatically log in after registration ([\matrix-org#8654](matrix-org#8654)). Fixes element-hq/element-web#19305. Contributed by @justjanne. * Fix offline status in window title not working reliably ([\matrix-org#8656](matrix-org#8656)). * Align input area with event body's first letter in a thread on IRC/modern layout ([\matrix-org#8636](matrix-org#8636)). Fixes element-hq/element-web#22252. Contributed by @luixxiul. * Fix crash on null idp for SSO buttons ([\matrix-org#8650](matrix-org#8650)). Contributed by @hughns. * Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\matrix-org#8648](matrix-org#8648)). Fixes element-hq/element-web#22279. * Show notifications even when Element is focused ([\matrix-org#8590](matrix-org#8590)). Contributed by @sumnerevans. * Remove padding from the buttons on edit message composer of a event tile on a thread ([\matrix-org#8632](matrix-org#8632)). Contributed by @luixxiul. * ensure metaspace changes correctly notify listeners ([\matrix-org#8611](matrix-org#8611)). Fixes element-hq/element-web#21006. Contributed by @justjanne. * Hide image banner on stickers, they have a tooltip already ([\matrix-org#8641](matrix-org#8641)). Fixes element-hq/element-web#22244. * Adjust EditMessageComposer style declarations ([\matrix-org#8631](matrix-org#8631)). Fixes element-hq/element-web#22231. Contributed by @luixxiul.
SchildiChat · Jun 7, 2022 · 56703ed · 56703ed
2 parents ac7a1dc + cacdb69
commit 56703ed
Show file tree

Hide file tree

Showing 165 changed files with 4,721 additions and 2,075 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -115,6 +115,8 @@ module.exports = {
                 "@typescript-eslint/no-explicit-any": "off",
                 // We'd rather not do this but we do
                 "@typescript-eslint/ban-ts-comment": "off",
+                // We're okay with assertion errors when we ask for them
+                "@typescript-eslint/no-non-null-assertion": "off",
             },
         },
         // temporary override for offending icon require files

diff --git a/.github/workflows/element-build-and-test.yaml b/.github/workflows/element-build-and-test.yaml
@@ -71,6 +71,7 @@ jobs:
           # to run the tests, so use chrome.
           browser: chrome
           start: npx serve -p 8080 webapp
+          wait-on: 'http://localhost:8080'
           record: true
           command-prefix: 'yarn percy exec --'
         env:
@@ -83,6 +84,8 @@ jobs:
           PERCY_BROWSER_EXECUTABLE: /usr/bin/chromium-browser
           # pass GitHub token to allow accurately detecting a build vs a re-run build
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          # make Node's os.tmpdir() return something where we actually have permissions
+          TMPDIR: ${{ runner.temp }}
 
       - name: Upload Artifact
         if: failure()

diff --git a/.github/workflows/i18n_check.yml b/.github/workflows/i18n_check.yml
@@ -0,0 +1,40 @@
+name: i18n Check
+on:
+  workflow_call: { }
+jobs:
+  check:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: read
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: "Get modified files"
+        id: changed_files
+        if: github.event_name == 'pull_request' && github.event.pull_request.user.login != 'RiotTranslateBot'
+        uses: tj-actions/changed-files@v19
+        with:
+          files: |
+            src/i18n/strings/*
+          files_ignore: |
+            src/i18n/strings/en_EN.json
+
+      - name: "Assert only en_EN was modified"
+        if: |
+          github.event_name == 'pull_request' &&
+          github.event.pull_request.user.login != 'RiotTranslateBot' &&
+          steps.changed_files.outputs.any_modified == 'true'
+        run: |
+          echo "Only translation files modified by `yarn i18n` can be committed - other translation files will confuse weblate in unrecoverable ways."
+          exit 1
+
+      - uses: actions/setup-node@v3
+        with:
+          cache: 'yarn'
+
+      # Does not need branch matching as only analyses this layer
+      - name: Install Deps
+        run: "yarn install --pure-lockfile"
+
+      - name: i18n Check
+        run: "yarn run diff-i18n"
diff --git a/.github/workflows/pull_request.yaml b/.github/workflows/pull_request.yaml
@@ -2,6 +2,7 @@ name: Pull Request
 on:
   pull_request_target:
     types: [ opened, edited, labeled, unlabeled, synchronize ]
+concurrency: ${{ github.workflow }}-${{ github.event.pull_request.head.ref }}
 jobs:
   changelog:
     name: Preview Changelog

diff --git a/.github/workflows/sonarqube.yml b/.github/workflows/sonarqube.yml
@@ -5,7 +5,7 @@ on:
     types:
       - completed
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
+  group: ${{ github.workflow }}-${{ github.event.workflow_run.head_branch }}
   cancel-in-progress: true
 jobs:
   prdetails:

diff --git a/.github/workflows/static_analysis.yaml b/.github/workflows/static_analysis.yaml
@@ -39,41 +39,7 @@ jobs:
 
   i18n_lint:
     name: "i18n Check"
-    runs-on: ubuntu-latest
-    permissions:
-      pull-requests: read
-    steps:
-      - uses: actions/checkout@v2
-
-      - name: "Get modified files"
-        id: changed_files
-        if: github.event_name == 'pull_request' && github.actor != 'RiotTranslateBot'
-        uses: tj-actions/changed-files@v19
-        with:
-          files: |
-            src/i18n/strings/*
-          files_ignore: |
-            src/i18n/strings/en_EN.json
-
-      - name: "Assert only en_EN was modified"
-        if: |
-          github.event_name == 'pull_request' &&
-          github.actor != 'RiotTranslateBot' &&
-          steps.changed_files.outputs.any_modified == 'true'
-        run: |
-          echo "You can only modify en_EN.json, do not touch any of the other i18n files as Weblate will be confused"
-          exit 1
-
-      - uses: actions/setup-node@v3
-        with:
-          cache: 'yarn'
-
-      # Does not need branch matching as only analyses this layer
-      - name: Install Deps
-        run: "yarn install"
-
-      - name: i18n Check
-        run: "yarn run diff-i18n"
+    uses: matrix-org/matrix-react-sdk/.github/workflows/i18n_check.yml@develop
 
   js_lint:
     name: "ESLint"

diff --git a/.gitignore b/.gitignore
@@ -27,5 +27,4 @@ package-lock.json
 /cypress/synapselogs
 # These could have files in them but don't currently
 # Cypress will still auto-create them though...
-/cypress/fixtures
 /cypress/performance
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,57 @@
+Changes in [3.46.0](https://github.com/matrix-org/matrix-react-sdk/releases/tag/v3.46.0) (2022-06-07)
+=====================================================================================================
+
+## ✨ Features
+ * Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\#7790](https://github.com/matrix-org/matrix-react-sdk/pull/7790)). Contributed by @johannes-krude.
+ * Live location sharing - open location in OpenStreetMap ([\#8695](https://github.com/matrix-org/matrix-react-sdk/pull/8695)). Contributed by @kerryarchibald.
+ * Show a dialog when Jitsi encounters an error ([\#8701](https://github.com/matrix-org/matrix-react-sdk/pull/8701)). Fixes vector-im/element-web#22284.
+ * Add support for setting the `avatar_url` of widgets by integration managers. ([\#8550](https://github.com/matrix-org/matrix-react-sdk/pull/8550)). Contributed by @Fox32.
+ * Add an option to ignore (block) a user when reporting their events ([\#8471](https://github.com/matrix-org/matrix-react-sdk/pull/8471)).
+ * Add the option to disable hardware acceleration ([\#8655](https://github.com/matrix-org/matrix-react-sdk/pull/8655)). Contributed by @novocaine.
+ * Slightly better presentation of read receipts to screen reader users ([\#8662](https://github.com/matrix-org/matrix-react-sdk/pull/8662)). Fixes vector-im/element-web#22293. Contributed by @pvagner.
+ * Add jump to related event context menu item ([\#6775](https://github.com/matrix-org/matrix-react-sdk/pull/6775)). Fixes vector-im/element-web#19883.
+ * Add public room directory hook ([\#8626](https://github.com/matrix-org/matrix-react-sdk/pull/8626)).
+
+## 🐛 Bug Fixes
+ * Remove inline margin from UTD error message inside a reply tile on ThreadView ([\#8708](https://github.com/matrix-org/matrix-react-sdk/pull/8708)). Fixes vector-im/element-web#22376. Contributed by @luixxiul.
+ * Move unread notification dots of the threads list to the expected position ([\#8700](https://github.com/matrix-org/matrix-react-sdk/pull/8700)). Fixes vector-im/element-web#22350. Contributed by @luixxiul.
+ * Prevent overflow of grid items on a bubble with UTD generally ([\#8697](https://github.com/matrix-org/matrix-react-sdk/pull/8697)). Contributed by @luixxiul.
+ * Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\#8704](https://github.com/matrix-org/matrix-react-sdk/pull/8704)). Fixes vector-im/element-web#22365. Contributed by @luixxiul.
+ * Fix - AccessibleButton does not set disabled attribute ([\#8682](https://github.com/matrix-org/matrix-react-sdk/pull/8682)). Contributed by @kerryarchibald.
+ * Fix font not resetting when logging out ([\#8670](https://github.com/matrix-org/matrix-react-sdk/pull/8670)). Fixes vector-im/element-web#17228.
+ * Fix local aliases section of room settings not working for some homeservers (ie ([\#8698](https://github.com/matrix-org/matrix-react-sdk/pull/8698)). Fixes vector-im/element-web#22337.
+ * Align EventTile_line with display name on message bubble ([\#8692](https://github.com/matrix-org/matrix-react-sdk/pull/8692)). Fixes vector-im/element-web#22343. Contributed by @luixxiul.
+ * Convert references to direct chat -> direct message ([\#8694](https://github.com/matrix-org/matrix-react-sdk/pull/8694)). Contributed by @novocaine.
+ * Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\#8687](https://github.com/matrix-org/matrix-react-sdk/pull/8687)).
+ * Make the empty thread panel fill BaseCard ([\#8690](https://github.com/matrix-org/matrix-react-sdk/pull/8690)). Fixes vector-im/element-web#22338. Contributed by @luixxiul.
+ * Fix edge case around composer handling gendered facepalm emoji ([\#8686](https://github.com/matrix-org/matrix-react-sdk/pull/8686)).
+ * Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\#8688](https://github.com/matrix-org/matrix-react-sdk/pull/8688)). Fixes vector-im/element-web#21914. Contributed by @luixxiul.
+ * Apply the same max-width to image tile on the thread timeline as message bubble ([\#8669](https://github.com/matrix-org/matrix-react-sdk/pull/8669)). Fixes vector-im/element-web#22313. Contributed by @luixxiul.
+ * Fix dropdown button size for picture-in-picture CallView ([\#8680](https://github.com/matrix-org/matrix-react-sdk/pull/8680)). Fixes vector-im/element-web#22316. Contributed by @luixxiul.
+ * Live location sharing - fix square border for image-less avatar (PSF-1052) ([\#8679](https://github.com/matrix-org/matrix-react-sdk/pull/8679)). Contributed by @kerryarchibald.
+ * Stop connecting to a video room if the widget messaging disappears ([\#8660](https://github.com/matrix-org/matrix-react-sdk/pull/8660)).
+ * Fix file button and audio player overflowing from message bubble ([\#8666](https://github.com/matrix-org/matrix-react-sdk/pull/8666)). Fixes vector-im/element-web#22308. Contributed by @luixxiul.
+ * Don't show broken composer format bar when selection is whitespace ([\#8673](https://github.com/matrix-org/matrix-react-sdk/pull/8673)). Fixes vector-im/element-web#10788.
+ * Fix media upload http 413 handling ([\#8674](https://github.com/matrix-org/matrix-react-sdk/pull/8674)).
+ * Fix emoji picker for editing thread responses ([\#8671](https://github.com/matrix-org/matrix-react-sdk/pull/8671)). Fixes matrix-org/element-web-rageshakes#13129.
+ * Map attribution while sharing live location is now visible ([\#8621](https://github.com/matrix-org/matrix-react-sdk/pull/8621)). Fixes vector-im/element-web#22236. Contributed by @weeman1337.
+ * Fix info tile overlapping the time stamp on TimelineCard ([\#8639](https://github.com/matrix-org/matrix-react-sdk/pull/8639)). Fixes vector-im/element-web#22256. Contributed by @luixxiul.
+ * Fix position of wide images on IRC / modern layout ([\#8667](https://github.com/matrix-org/matrix-react-sdk/pull/8667)). Fixes vector-im/element-web#22309. Contributed by @luixxiul.
+ * Fix other user's displayName being wrapped on the bubble message layout ([\#8456](https://github.com/matrix-org/matrix-react-sdk/pull/8456)). Fixes vector-im/element-web#22004. Contributed by @luixxiul.
+ * Set spacing declarations to elements in mx_EventTile_mediaLine ([\#8665](https://github.com/matrix-org/matrix-react-sdk/pull/8665)). Fixes vector-im/element-web#22307. Contributed by @luixxiul.
+ * Fix wide image overflowing from the thumbnail container ([\#8663](https://github.com/matrix-org/matrix-react-sdk/pull/8663)). Fixes vector-im/element-web#22303. Contributed by @luixxiul.
+ * Fix styles of "Show all" link button on ReactionsRow ([\#8658](https://github.com/matrix-org/matrix-react-sdk/pull/8658)). Fixes vector-im/element-web#22300. Contributed by @luixxiul.
+ * Automatically log in after registration ([\#8654](https://github.com/matrix-org/matrix-react-sdk/pull/8654)). Fixes vector-im/element-web#19305. Contributed by @justjanne.
+ * Fix offline status in window title not working reliably ([\#8656](https://github.com/matrix-org/matrix-react-sdk/pull/8656)).
+ * Align input area with event body's first letter in a thread on IRC/modern layout ([\#8636](https://github.com/matrix-org/matrix-react-sdk/pull/8636)). Fixes vector-im/element-web#22252. Contributed by @luixxiul.
+ * Fix crash on null idp for SSO buttons ([\#8650](https://github.com/matrix-org/matrix-react-sdk/pull/8650)). Contributed by @hughns.
+ * Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\#8648](https://github.com/matrix-org/matrix-react-sdk/pull/8648)). Fixes vector-im/element-web#22279.
+ * Show notifications even when Element is focused ([\#8590](https://github.com/matrix-org/matrix-react-sdk/pull/8590)). Contributed by @sumnerevans.
+ * Remove padding from the buttons on edit message composer of a event tile on a thread ([\#8632](https://github.com/matrix-org/matrix-react-sdk/pull/8632)). Contributed by @luixxiul.
+ * ensure metaspace changes correctly notify listeners ([\#8611](https://github.com/matrix-org/matrix-react-sdk/pull/8611)). Fixes vector-im/element-web#21006. Contributed by @justjanne.
+ * Hide image banner on stickers, they have a tooltip already ([\#8641](https://github.com/matrix-org/matrix-react-sdk/pull/8641)). Fixes vector-im/element-web#22244.
+ * Adjust EditMessageComposer style declarations ([\#8631](https://github.com/matrix-org/matrix-react-sdk/pull/8631)). Fixes vector-im/element-web#22231. Contributed by @luixxiul.
+
 Changes in [3.45.0](https://github.com/matrix-org/matrix-react-sdk/releases/tag/v3.45.0) (2022-05-24)
 =====================================================================================================