Release candidate 4.5.0 #1473
Closed
Release candidate 4.5.0 #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reading config files, Sceptre caches the variables used by Jinja. If a template is missing a variable, one from a different StackGroup is used instead.
…le stacks Previously the update command would exit if any change sets status was not equal to READY. However, when a stack does not contain any updates, it will not be READY since there is nothing to execute. This should not prevent other change sets to be executed. To get around this, we introduce another change set status, NO_CHANGES, and handle that gracefully. To clean up the output a bit, we also pass on describing the changes for empty change sets.
This resolves a bug in `sceptre outputs` where all `ClientError` exceptions (e.g. `ExpiredToken`) are suppressed, for no apparent reason. In 682a306, (October 2018, commit summary "Move Stack operations from Stack to StackActions"), a big refactor had occurred. That refactor had introduced a public method `describe` in the `StackActions` class. A month later, in 182f0b6 (November 2018, commit summary "Implement algorithm to execute Stacks from StackGraph"), another big refactor occurred. A part of that refactor was to introduce an essentially duplicate method `_describe` and then in the `describe_output` method, catch all `ClientError` exceptions and always return an empty list. So far as I can tell, there was no good reason to introduce either the new method, or catch all `ClientError` exceptions. The suppression of exceptions may have been accidental, or a hack to get the unit tests to pass. This patch attempts to fix all of this up: - Duplicate method removed in favour of the public `describe` method. I have opted to keep the public method as the differ class is calling, making it public. - The change to `describe_outputs` is reverted. - The unit tests are rewritten.
Akin to `sceptre delete`, display the order of operations when issuing `sceptre launch` for a visual representation of dependencies.
This adds logic supporting the case of creating change sets for a stack that does not already exist, i.e. specifying ChangeSetType of CREATE. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudformation/client/create_change_set.html
This reverts commit 906005d.
for more information, see https://pre-commit.ci
In already-resolved and merged issue Sceptre#1443 we implemented parameter validation. Subsequent discussion led to a consensus that it would be better to not only validate parameters, but also cast where applicable to string. This will lead to a cleaner user experience for most Sceptre users where parameters passed as ints, floats and bools in their YAML values files are cast to strings first and then sent to CloudFormation, since CloudFormation's API is unable to handle other types. This PR changes the behaviour of the `_ensure_parameters` method in the Stack class to handle casting to strings where applicable instead of only validating.
This reverts commit c0318bf.
…release-candidate-4.5.0
…release-candidate-4.5.0
for more information, see https://pre-commit.ci
This adds logic to _cast_parameters to also handle the case that the `parameters` dict itself is not a dict but some other invalid type.
This adds code to handle the case of failures in stack groups that have missing or errored stacks when creating, describing and executing change-sets. Before this, any stack group that contained a stack that had been deleted, or had errored out, resulted in all change set operations on that stack group failing. The reason for this is no error or exception handling had ever been added for change sets, but assumed all stacks in the stack group were clean and could respond to the change set APIs. For example, deleting change sets might error out with: ``` % sceptre delete -y network.yaml sceptre-network The Change Set will be delete on the following stacks, if applicable: network "An error occurred (ValidationError) when calling the DeleteChangeSet operation: Stack [test-e2e-direct-connect] does not exist" ``` This is particularly an issue for sites that employ as best practice analysis of change sets for safety prior to launching updates. This patch adds the missing error handling for `delete_change_set`, `create_change_set`, `describe_change_set` and `execute_change_set`.
for more information, see https://pre-commit.ci
|
All in master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch merges these PRs for local testing with a view to releasing as Sceptre v4.5.0.
PR Checklist
[Resolve #issue-number].poetry run tox) are passing.poetry run pre-commit run --all-files).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit