Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest #11

Merged
merged 28 commits into from
Sep 1, 2021
Merged

Bump to latest #11

merged 28 commits into from
Sep 1, 2021

Conversation

rookiejava
Copy link
Contributor

This PR includes below changes:

  • Common
    • Adds net6.0-tizen TFM
  • ElmSharp
    • Fix color type for Shell
    • Add Tabs
    • Fix tabstype name
    • Fix Image.Measure()
    • Modify NavigationView
  • NUI
    • Fix GraphicsView scaling issue
    • Update SKCanvasView/SKGLSurfaceView to use NativeImageQueue
    • Add NavigationStack
    • Update Stream Image source
    • Fix to use Top instead _lastTop

@rookiejava rookiejava requested review from myroot and shyunMin and removed request for myroot and shyunMin September 1, 2021 03:59
myroot
myroot previously approved these changes Sep 1, 2021
src/Tizen.UIExtensions.NUI/CollectionView/ViewHolder.cs Outdated Show resolved Hide resolved
/// Handle Selected item
/// </summary>
/// <param name="selected"></param>
public virtual void SendItemSelected(IEnumerable<int> selected)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method already exists in line 90.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this method

src/Tizen.UIExtensions.NUI/CollectionView/ItemAdaptor.cs Outdated Show resolved Hide resolved
@rookiejava rookiejava merged commit 1669a71 into Samsung:main Sep 1, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants