-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to latest #11
Merged
Merged
Bump to latest #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the SkiaSharp version to latest and use Microsoft.Maui.Graphics.Skia
Fix build warning on packing
Fix GraphicsView scaling issue
[NUI] Add NavigationStack
* Update SKCanvasView to use NativeImageQueue * Fix nullable
Adds net6.0-tizen TFM
rookiejava
requested review from
myroot and
shyunMin
and removed request for
myroot and
shyunMin
September 1, 2021 03:59
myroot
previously approved these changes
Sep 1, 2021
shyunMin
reviewed
Sep 1, 2021
/// Handle Selected item | ||
/// </summary> | ||
/// <param name="selected"></param> | ||
public virtual void SendItemSelected(IEnumerable<int> selected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method already exists in line 90.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this method
shyunMin
approved these changes
Sep 1, 2021
sung-su
approved these changes
Sep 1, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes below changes: