Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the coverflow element and Fix stability #314

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Set the coverflow element and Fix stability #314

merged 1 commit into from
Sep 10, 2019

Conversation

DohyungLim
Copy link
Contributor

  • Set the default value to the coverflow element.
  • Remove 'Widget Option' Attribute.
  • External images apply to coverflow.
  • After Images select, effect and size select as possible.

Signed-off-by: DoHyung Lim delight.lim@samsung.com

TomaszLukawskiSam
TomaszLukawskiSam reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@TomaszLukawskiSam TomaszLukawskiSam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have broken attribute list after this change.
image

@DohyungLim
Copy link
Contributor Author

@TomaszLukawskiSam
It's very strange.
I checked the implementation in VSC-Design-Editor.
The attached image does not break as shown.
I copied the code implemented in VSC-Design-Editor to TAU-Design-Editor equally.
Does updating to TAU-Design-Editor apply to VSC-Design-Editor?

Wouldn't the issue occur somewhere else? please check.

@singa2000 singa2000 mentioned this pull request Sep 6, 2019
Closed
@DohyungLim
Copy link
Contributor Author

@korneliakobiela
Tomasz says that the Attributes Tab breaks.
I and Ms.Hwang (Cookie) confirmed on the local PC that the issue was resolved.

can you please this issue reproduce on your PC?
If you have same attributes tab break, can you guide my PR problem?

@DohyungLim
Set the coverflow element and Fix stability
2a4f796 
- Set the default value to the coverflow element.
- Remove 'Widget Option' Attribute.
- External images apply to coverflow.
- After Images select, effect and size select as possible.

Signed-off-by: DoHyung Lim <delight.lim@samsung.com>
@DohyungLim
Copy link
Contributor Author

@TomaszLukawskiSam
Sorry. There is a modification in my code to eliminate Lint errors.
The problem arises here. I updated the code with changes.
Please check it last.

@TomaszLukawskiSam
Copy link
Contributor

@TomaszLukawskiSam
Sorry. There is a modification in my code to eliminate Lint errors.
The problem arises here. I updated the code with changes.
Please check it last.
@DohyungLim
The attributes look good :)

TomaszLukawskiSam
TomaszLukawskiSam approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@TomaszLukawskiSam TomaszLukawskiSam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@DohyungLim
Copy link
Contributor Author

@TomaszLukawskiSam @korneliakobiela
please merge to this PR.

@singa2000 singa2000 merged commit d8a078b into Samsung:master Sep 10, 2019
korneliakobiela pushed a commit to korneliakobiela/TAU-Design-Editor that referenced this pull request Sep 12, 2019
Release 0.7.0
1660ed4 
d92a304 Add relative path to image src
890c85c Fix preview position
072ec87 Widget progress draggable in wearable profile.
7e331ef Fix slider behaviour on focus
c2b9903 Add test & fix _compareVersions in component-element
d8a078b Set the coverflow element and Fix stability (Samsung#314)
c1ea59e Make input-text, input-number, progress widgets selectable and draggable
116c6cb Enable dragging listview itself
c82d724 Add button to reset background color
4c2522b Make button to return to Editor mode more intuitive.
e64bf4a Disable styles from styles panel for wearable.
65a9e1b Enable adding header to the empty page
232a9a1 Fix size reset after deselect image issue
018ad2f DropDownMenu: widget doesn't update after options change
e74970c Hide Text Attribute for components that doesn't contain text
1aff2cd Change preset style setting mechanism
2b45836 Components Panel: fix for widget visibility depende to screen shape
cdf875c Fill attributes panel elements with computed value
bf3f176 Fix component multiplication after drag&drop
5ed5258 Call refresh method after changing style
430abc3 Remove the Behavior->Events->animation (Samsung#306)
8cee5aa Add hints to inputs with when mouse over
6f7f0a8 Add placeholders to elements with no value
dac0e05 Merge pull request Samsung#299 from singa2000/widget_option
56030ca TextInput: Fix for moving text input component
0afba63 Remove the Attributes->Element->Widget options
1534d7c Merge pull request Samsung#289 from HunseopJeong/background
11bd46d Make code of guide.js more readable & maintainable
bdda39f Closing HTML Assistant on loose element focus
aa14975 Merge pull request Samsung#295 from singa2000/header
5f7f94e Enable adding the image and checkbox widgets to header
1e95650 Merge pull request Samsung#286 from singa2000/del_layout
66094ce Set the default size of the i3d element
3924a30 Remove the Layout attribute
1e3171b Enable adding the text and image widgets to header
0d1f568 Prevent page wizard broken while DE scaling
8b4efe2 Enable element removing after select it indirectely
61f049d Fix lint errors
cdc9e94 Enable Selector and Selector Item widgets

Signed-off-by: Kornelia Kobiela <k.kobiela@samsung.com>
@korneliakobiela korneliakobiela mentioned this pull request Sep 12, 2019
Merged
korneliakobiela pushed a commit that referenced this pull request Sep 12, 2019
Release 0.7.0
43fbd7a 
d92a304 Add relative path to image src
890c85c Fix preview position
072ec87 Widget progress draggable in wearable profile.
7e331ef Fix slider behaviour on focus
c2b9903 Add test & fix _compareVersions in component-element
d8a078b Set the coverflow element and Fix stability (#314)
c1ea59e Make input-text, input-number, progress widgets selectable and draggable
116c6cb Enable dragging listview itself
c82d724 Add button to reset background color
4c2522b Make button to return to Editor mode more intuitive.
e64bf4a Disable styles from styles panel for wearable.
65a9e1b Enable adding header to the empty page
232a9a1 Fix size reset after deselect image issue
018ad2f DropDownMenu: widget doesn't update after options change
e74970c Hide Text Attribute for components that doesn't contain text
1aff2cd Change preset style setting mechanism
2b45836 Components Panel: fix for widget visibility depende to screen shape
cdf875c Fill attributes panel elements with computed value
bf3f176 Fix component multiplication after drag&drop
5ed5258 Call refresh method after changing style
430abc3 Remove the Behavior->Events->animation (#306)
8cee5aa Add hints to inputs with when mouse over
6f7f0a8 Add placeholders to elements with no value
dac0e05 Merge pull request #299 from singa2000/widget_option
56030ca TextInput: Fix for moving text input component
0afba63 Remove the Attributes->Element->Widget options
1534d7c Merge pull request #289 from HunseopJeong/background
11bd46d Make code of guide.js more readable & maintainable
bdda39f Closing HTML Assistant on loose element focus
aa14975 Merge pull request #295 from singa2000/header
5f7f94e Enable adding the image and checkbox widgets to header
1e95650 Merge pull request #286 from singa2000/del_layout
66094ce Set the default size of the i3d element
3924a30 Remove the Layout attribute
1e3171b Enable adding the text and image widgets to header
0d1f568 Prevent page wizard broken while DE scaling
8b4efe2 Enable element removing after select it indirectely
61f049d Fix lint errors
cdc9e94 Enable Selector and Selector Item widgets

Signed-off-by: Kornelia Kobiela <k.kobiela@samsung.com>
wszczepanski97 pushed a commit to wszczepanski97/TAU-Design-Editor that referenced this pull request Sep 17, 2019
@DohyungLim @wszczepanski97
Set the coverflow element and Fix stability (Samsung#314)
4067bd7 
- Set the default value to the coverflow element.
- Remove 'Widget Option' Attribute.
- External images apply to coverflow.
- After Images select, effect and size select as possible.

Signed-off-by: DoHyung Lim <delight.lim@samsung.com>
wszczepanski97 pushed a commit to wszczepanski97/TAU-Design-Editor that referenced this pull request Sep 17, 2019
@wszczepanski97
Release 0.7.0
f269aad 
d92a304 Add relative path to image src
890c85c Fix preview position
072ec87 Widget progress draggable in wearable profile.
7e331ef Fix slider behaviour on focus
c2b9903 Add test & fix _compareVersions in component-element
d8a078b Set the coverflow element and Fix stability (Samsung#314)
c1ea59e Make input-text, input-number, progress widgets selectable and draggable
116c6cb Enable dragging listview itself
c82d724 Add button to reset background color
4c2522b Make button to return to Editor mode more intuitive.
e64bf4a Disable styles from styles panel for wearable.
65a9e1b Enable adding header to the empty page
232a9a1 Fix size reset after deselect image issue
018ad2f DropDownMenu: widget doesn't update after options change
e74970c Hide Text Attribute for components that doesn't contain text
1aff2cd Change preset style setting mechanism
2b45836 Components Panel: fix for widget visibility depende to screen shape
cdf875c Fill attributes panel elements with computed value
bf3f176 Fix component multiplication after drag&drop
5ed5258 Call refresh method after changing style
430abc3 Remove the Behavior->Events->animation (Samsung#306)
8cee5aa Add hints to inputs with when mouse over
6f7f0a8 Add placeholders to elements with no value
dac0e05 Merge pull request Samsung#299 from singa2000/widget_option
56030ca TextInput: Fix for moving text input component
0afba63 Remove the Attributes->Element->Widget options
1534d7c Merge pull request Samsung#289 from HunseopJeong/background
11bd46d Make code of guide.js more readable & maintainable
bdda39f Closing HTML Assistant on loose element focus
aa14975 Merge pull request Samsung#295 from singa2000/header
5f7f94e Enable adding the image and checkbox widgets to header
1e95650 Merge pull request Samsung#286 from singa2000/del_layout
66094ce Set the default size of the i3d element
3924a30 Remove the Layout attribute
1e3171b Enable adding the text and image widgets to header
0d1f568 Prevent page wizard broken while DE scaling
8b4efe2 Enable element removing after select it indirectely
61f049d Fix lint errors
cdc9e94 Enable Selector and Selector Item widgets

Signed-off-by: Kornelia Kobiela <k.kobiela@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomaszLukawskiSam TomaszLukawskiSam TomaszLukawskiSam approved these changes

@korneliakobiela korneliakobiela Awaiting requested review from korneliakobiela

@hsiwkin hsiwkin Awaiting requested review from hsiwkin

@pkaczmarczy pkaczmarczy Awaiting requested review from pkaczmarczy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DohyungLim @TomaszLukawskiSam @singa2000