-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable adding the image and checkbox widgets to header #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue : Samsung#261 Problem : Can't add the image widget in header Solution:Add it to constraint in header widget manifest Signed-off-by: cookie <cookie@samsung.com>
wszczepanski97
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🌞
korneliakobiela
pushed a commit
to korneliakobiela/TAU-Design-Editor
that referenced
this pull request
Sep 12, 2019
d92a304 Add relative path to image src 890c85c Fix preview position 072ec87 Widget progress draggable in wearable profile. 7e331ef Fix slider behaviour on focus c2b9903 Add test & fix _compareVersions in component-element d8a078b Set the coverflow element and Fix stability (Samsung#314) c1ea59e Make input-text, input-number, progress widgets selectable and draggable 116c6cb Enable dragging listview itself c82d724 Add button to reset background color 4c2522b Make button to return to Editor mode more intuitive. e64bf4a Disable styles from styles panel for wearable. 65a9e1b Enable adding header to the empty page 232a9a1 Fix size reset after deselect image issue 018ad2f DropDownMenu: widget doesn't update after options change e74970c Hide Text Attribute for components that doesn't contain text 1aff2cd Change preset style setting mechanism 2b45836 Components Panel: fix for widget visibility depende to screen shape cdf875c Fill attributes panel elements with computed value bf3f176 Fix component multiplication after drag&drop 5ed5258 Call refresh method after changing style 430abc3 Remove the Behavior->Events->animation (Samsung#306) 8cee5aa Add hints to inputs with when mouse over 6f7f0a8 Add placeholders to elements with no value dac0e05 Merge pull request Samsung#299 from singa2000/widget_option 56030ca TextInput: Fix for moving text input component 0afba63 Remove the Attributes->Element->Widget options 1534d7c Merge pull request Samsung#289 from HunseopJeong/background 11bd46d Make code of guide.js more readable & maintainable bdda39f Closing HTML Assistant on loose element focus aa14975 Merge pull request Samsung#295 from singa2000/header 5f7f94e Enable adding the image and checkbox widgets to header 1e95650 Merge pull request Samsung#286 from singa2000/del_layout 66094ce Set the default size of the i3d element 3924a30 Remove the Layout attribute 1e3171b Enable adding the text and image widgets to header 0d1f568 Prevent page wizard broken while DE scaling 8b4efe2 Enable element removing after select it indirectely 61f049d Fix lint errors cdc9e94 Enable Selector and Selector Item widgets Signed-off-by: Kornelia Kobiela <k.kobiela@samsung.com>
Merged
korneliakobiela
pushed a commit
that referenced
this pull request
Sep 12, 2019
d92a304 Add relative path to image src 890c85c Fix preview position 072ec87 Widget progress draggable in wearable profile. 7e331ef Fix slider behaviour on focus c2b9903 Add test & fix _compareVersions in component-element d8a078b Set the coverflow element and Fix stability (#314) c1ea59e Make input-text, input-number, progress widgets selectable and draggable 116c6cb Enable dragging listview itself c82d724 Add button to reset background color 4c2522b Make button to return to Editor mode more intuitive. e64bf4a Disable styles from styles panel for wearable. 65a9e1b Enable adding header to the empty page 232a9a1 Fix size reset after deselect image issue 018ad2f DropDownMenu: widget doesn't update after options change e74970c Hide Text Attribute for components that doesn't contain text 1aff2cd Change preset style setting mechanism 2b45836 Components Panel: fix for widget visibility depende to screen shape cdf875c Fill attributes panel elements with computed value bf3f176 Fix component multiplication after drag&drop 5ed5258 Call refresh method after changing style 430abc3 Remove the Behavior->Events->animation (#306) 8cee5aa Add hints to inputs with when mouse over 6f7f0a8 Add placeholders to elements with no value dac0e05 Merge pull request #299 from singa2000/widget_option 56030ca TextInput: Fix for moving text input component 0afba63 Remove the Attributes->Element->Widget options 1534d7c Merge pull request #289 from HunseopJeong/background 11bd46d Make code of guide.js more readable & maintainable bdda39f Closing HTML Assistant on loose element focus aa14975 Merge pull request #295 from singa2000/header 5f7f94e Enable adding the image and checkbox widgets to header 1e95650 Merge pull request #286 from singa2000/del_layout 66094ce Set the default size of the i3d element 3924a30 Remove the Layout attribute 1e3171b Enable adding the text and image widgets to header 0d1f568 Prevent page wizard broken while DE scaling 8b4efe2 Enable element removing after select it indirectely 61f049d Fix lint errors cdc9e94 Enable Selector and Selector Item widgets Signed-off-by: Kornelia Kobiela <k.kobiela@samsung.com>
wszczepanski97
pushed a commit
to wszczepanski97/TAU-Design-Editor
that referenced
this pull request
Sep 17, 2019
d92a304 Add relative path to image src 890c85c Fix preview position 072ec87 Widget progress draggable in wearable profile. 7e331ef Fix slider behaviour on focus c2b9903 Add test & fix _compareVersions in component-element d8a078b Set the coverflow element and Fix stability (Samsung#314) c1ea59e Make input-text, input-number, progress widgets selectable and draggable 116c6cb Enable dragging listview itself c82d724 Add button to reset background color 4c2522b Make button to return to Editor mode more intuitive. e64bf4a Disable styles from styles panel for wearable. 65a9e1b Enable adding header to the empty page 232a9a1 Fix size reset after deselect image issue 018ad2f DropDownMenu: widget doesn't update after options change e74970c Hide Text Attribute for components that doesn't contain text 1aff2cd Change preset style setting mechanism 2b45836 Components Panel: fix for widget visibility depende to screen shape cdf875c Fill attributes panel elements with computed value bf3f176 Fix component multiplication after drag&drop 5ed5258 Call refresh method after changing style 430abc3 Remove the Behavior->Events->animation (Samsung#306) 8cee5aa Add hints to inputs with when mouse over 6f7f0a8 Add placeholders to elements with no value dac0e05 Merge pull request Samsung#299 from singa2000/widget_option 56030ca TextInput: Fix for moving text input component 0afba63 Remove the Attributes->Element->Widget options 1534d7c Merge pull request Samsung#289 from HunseopJeong/background 11bd46d Make code of guide.js more readable & maintainable bdda39f Closing HTML Assistant on loose element focus aa14975 Merge pull request Samsung#295 from singa2000/header 5f7f94e Enable adding the image and checkbox widgets to header 1e95650 Merge pull request Samsung#286 from singa2000/del_layout 66094ce Set the default size of the i3d element 3924a30 Remove the Layout attribute 1e3171b Enable adding the text and image widgets to header 0d1f568 Prevent page wizard broken while DE scaling 8b4efe2 Enable element removing after select it indirectely 61f049d Fix lint errors cdc9e94 Enable Selector and Selector Item widgets Signed-off-by: Kornelia Kobiela <k.kobiela@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #261
Problem : Can't add the image widget in header
Solution:Add it to constraint in header widget manifest
Signed-off-by: cookie cookie@samsung.com