Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Selector and Selector Item widgets #273

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

lmslachciak
Copy link
Contributor

[Issue] #191
[Problem] Selector and Selector item widgets are disabled
[Solution] Enable them after tests

Signed-off-by: Lukasz Slachciak l.slachciak@samsung.com

[Issue] Samsung#191
[Problem] Selector and Selector item widgets are disabled
[Solution] Enable them after tests

Signed-off-by: Lukasz Slachciak <l.slachciak@samsung.com>
@lmslachciak
Copy link
Contributor Author

lmslachciak commented Aug 13, 2019

@singa2000
Currently I don't see any major issues with selector and selector item.
The only problem which I see is that after deleting Selector Item inside of selector empty space exist, but it disappears after refreshing browser or going to preview mode
image
So I think we could enable it and fix this issue later

[Issue] Samsung#273
[Problem] Travis reports lint error
[Solution] Appl correct spacing in file

Signed-off-by: Lukasz Slachciak <l.slachciak@samsung.com>
@lmslachciak
Copy link
Contributor Author

Issue for empty space selector problem
#279

@lmslachciak
Copy link
Contributor Author

Issue for selector not visible
#279

@lmslachciak lmslachciak added this to the M2 milestone Aug 14, 2019
Copy link
Contributor

@hsiwkin hsiwkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lmslachciak lmslachciak merged commit 61f049d into Samsung:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants