Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selector - after deleting selector item unhighlighted empty space exists #279

Open
lmslachciak opened this issue Aug 14, 2019 · 3 comments
Open

Selector - after deleting selector item unhighlighted empty space exists #279

lmslachciak opened this issue Aug 14, 2019 · 3 comments
Assignees
@pkaczmarczy
Labels
1.0 bug Something isn't working in progress Someone is now working on this issue
Milestone
M2

Comments

@lmslachciak
Copy link
Contributor

  1. Create new wearable sample project
  2. Add Selector
  3. Add Few selector items
  4. Remove on selector item
  5. Observe

Expected Behaviur

  • no empty spacwe, selector widget is rebuild
    Observation:
    epty space
    image
@lmslachciak lmslachciak added the bug Something isn't working label Aug 14, 2019
@lmslachciak lmslachciak added this to the M2 milestone Aug 14, 2019
@lmslachciak lmslachciak mentioned this issue Aug 14, 2019
Merged
@pkaczmarczy pkaczmarczy self-assigned this Aug 22, 2019
@pkaczmarczy pkaczmarczy added in progress Someone is now working on this issue and removed in progress Someone is now working on this issue labels Aug 22, 2019
@pkaczmarczy pkaczmarczy added the in progress Someone is now working on this issue label Aug 23, 2019
@pkaczmarczy
Copy link
Collaborator

To solve this issue I need to create two PRs - one into TAU repository and the second one into Design - Editor.
The problem is quite complex, because item removal has to be done using Selector widget API - for now there is no generic API for all of the widget. I will extend selector API to accept index or HTMLElement of item to remove and add configurable design-editor method call on removal.

pkaczmarczy added a commit to pkaczmarczy/TAU that referenced this issue Aug 23, 2019
@pkaczmarczy
Extend Selector remove item API
5020258 
[Issue] Samsung/TAU-Design-Editor#279
[Problem] Selector item removal API that allows for removing
          items by HTMLElements would be helpful.
[Solution] Extend API to accept both index and HTMLElement

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
pkaczmarczy added a commit to pkaczmarczy/TAU-Design-Editor that referenced this issue Aug 23, 2019
@pkaczmarczy
Add configurable parent method call after deleting element
2b570d6 
[Issue] Samsung#279
[Problem] Some complex widgets require removing elements
          through its API. Otherwise widget look is broken.
[Solution] Call given parent method on widget if required

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
pkaczmarczy added a commit to pkaczmarczy/TAU-Design-Editor that referenced this issue Aug 23, 2019
@pkaczmarczy
Add configurable parent method call after deleting element
f14b003 
[Issue] Samsung#279
[Problem] Some complex widgets require removing elements
          through its API. Otherwise widget look is broken.
[Solution] Call given parent method on widget if required

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
@pkaczmarczy pkaczmarczy mentioned this issue Aug 23, 2019
Closed
pkaczmarczy added a commit to pkaczmarczy/TAU that referenced this issue Aug 23, 2019
@pkaczmarczy
Extend Selector remove item API
f25ce86 
[Issue] Samsung/TAU-Design-Editor#279
[Problem] Selector item removal API that allows for removing
          items by HTMLElements would be helpful.
[Solution] Extend API to accept both index and HTMLElement

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
@pkaczmarczy pkaczmarczy mentioned this issue Aug 23, 2019
Merged
@pkaczmarczy
Copy link
Collaborator

TAU PR: Samsung/TAU#341
DE PR: #296

pkaczmarczy added a commit to pkaczmarczy/TAU-Design-Editor that referenced this issue Aug 23, 2019
@pkaczmarczy
Add configurable parent method call after deleting element
74fdcb7 
[Issue] Samsung#279
[Problem] Some complex widgets require removing elements
          through its API. Otherwise widget look is broken.
[Solution] Call given parent method on widget if required

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
pkaczmarczy added a commit to pkaczmarczy/TAU that referenced this issue Aug 26, 2019
@pkaczmarczy
Extend Selector remove item API
df280f8 
[Issue] Samsung/TAU-Design-Editor#279
[Problem] Selector item removal API that allows for removing
          items by HTMLElements would be helpful.
[Solution] Extend API to accept both index and HTMLElement

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
pkaczmarczy added a commit to pkaczmarczy/TAU that referenced this issue Aug 27, 2019
@pkaczmarczy
Extend Selector remove item API
edceb2f 
[Issue] Samsung/TAU-Design-Editor#279
[Problem] Selector item removal API that allows for removing
          items by HTMLElements would be helpful.
[Solution] Extend API to accept both index and HTMLElement

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
pkaczmarczy added a commit to pkaczmarczy/TAU-Design-Editor that referenced this issue Aug 27, 2019
@pkaczmarczy
Add configurable parent method call after deleting element
f9005e5 
[Issue] Samsung#279
[Problem] Some complex widgets require removing elements
          through its API. Otherwise widget look is broken.
[Solution] Call given parent method on widget if required

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
pkaczmarczy added a commit to Samsung/TAU that referenced this issue Aug 28, 2019
@pkaczmarczy
Extend Selector remove item API
e439da3 
[Issue] Samsung/TAU-Design-Editor#279
[Problem] Selector item removal API that allows for removing
          items by HTMLElements would be helpful.
[Solution] Extend API to accept both index and HTMLElement

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
pkaczmarczy added a commit to pkaczmarczy/TAU-Design-Editor that referenced this issue Sep 5, 2019
@pkaczmarczy
Add configurable parent method call after deleting element
ab97730 
[Issue] Samsung#279
[Problem] Some complex widgets require removing elements
          through its API. Otherwise widget look is broken.
[Solution] Call given parent method on widget if required

Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
@lmslachciak lmslachciak removed the in progress Someone is now working on this issue label Sep 19, 2019
@pkaczmarczy
Copy link
Collaborator

PRs for this issue are still waiting for review. I will put back "in progress" label.

@pkaczmarczy pkaczmarczy added the in progress Someone is now working on this issue label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkaczmarczy pkaczmarczy

Labels
1.0 bug Something isn't working in progress Someone is now working on this issue
Projects
None yet
Milestone
M2
Development

No branches or pull requests
2 participants
@lmslachciak @pkaczmarczy